[v1] rtc: rtc-spear: set range max

[PATCH] rtc: rtc-spear: set range max

Posted by Zeng Jingxiang 3 years, 8 months ago

From: Zeng Jingxiang <linuszeng@tencent.com>

In the commit f395e1d3b28d7c2c67b73bd467c4fb79523e1c65 
("rtc: spear: set range"), the value of 
RTC_TIMESTAMP_END_9999 was incorrectly set to range_min.
390	config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
391	config->rtc->range_max = RTC_TIMESTAMP_END_9999;

Signed-off-by: Zeng Jingxiang <linuszeng@tencent.com>
---
 drivers/rtc/rtc-spear.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c
index d4777b01ab22..736fe535cd45 100644
--- a/drivers/rtc/rtc-spear.c
+++ b/drivers/rtc/rtc-spear.c
@@ -388,7 +388,7 @@ static int spear_rtc_probe(struct platform_device *pdev)
 
 	config->rtc->ops = &spear_rtc_ops;
 	config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
-	config->rtc->range_min = RTC_TIMESTAMP_END_9999;
+	config->rtc->range_max = RTC_TIMESTAMP_END_9999;
 
 	status = devm_rtc_register_device(config->rtc);
 	if (status)
-- 
2.27.0

Re: [PATCH] rtc: rtc-spear: set range max

Posted by Viresh Kumar 3 years, 8 months ago

On Thu, Jul 28, 2022 at 2:49 PM Zeng Jingxiang <zengjx95@gmail.com> wrote:
>
> From: Zeng Jingxiang <linuszeng@tencent.com>
>
> In the commit f395e1d3b28d7c2c67b73bd467c4fb79523e1c65

Please add this as fixes tag.

> ("rtc: spear: set range"), the value of
> RTC_TIMESTAMP_END_9999 was incorrectly set to range_min.
> 390     config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
> 391     config->rtc->range_max = RTC_TIMESTAMP_END_9999;
>
> Signed-off-by: Zeng Jingxiang <linuszeng@tencent.com>
> ---
>  drivers/rtc/rtc-spear.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c
> index d4777b01ab22..736fe535cd45 100644
> --- a/drivers/rtc/rtc-spear.c
> +++ b/drivers/rtc/rtc-spear.c
> @@ -388,7 +388,7 @@ static int spear_rtc_probe(struct platform_device *pdev)
>
>         config->rtc->ops = &spear_rtc_ops;
>         config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
> -       config->rtc->range_min = RTC_TIMESTAMP_END_9999;
> +       config->rtc->range_max = RTC_TIMESTAMP_END_9999;
>
>         status = devm_rtc_register_device(config->rtc);
>         if (status)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>