ARM: dts: turris-omnia: Add ethernet aliases

[PATCH] ARM: dts: turris-omnia: Add ethernet aliases

Posted by Pali Rohár 3 years, 8 months ago

This allows bootloader to correctly pass MAC addresses used by bootloader
to individual interfaces into kernel device tree.

Signed-off-by: Pali Rohár <pali@kernel.org>
---
 arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
index f4eb6898aa6b..d2afa466e29a 100644
--- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
+++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
@@ -23,6 +23,12 @@
 		stdout-path = &uart0;
 	};
 
+	aliases {
+		ethernet0 = &eth0;
+		ethernet1 = &eth1;
+		ethernet2 = &eth2;
+	};
+
 	memory {
 		device_type = "memory";
 		reg = <0x00000000 0x40000000>; /* 1024 MB */
-- 
2.20.1

Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases

Posted by Gregory CLEMENT 3 years, 4 months ago

Pali Rohár <pali@kernel.org> writes:

> This allows bootloader to correctly pass MAC addresses used by bootloader
> to individual interfaces into kernel device tree.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>

Applied on mvebu/dt

Thanks,

Gregory
> ---
>  arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f4eb6898aa6b..d2afa466e29a 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -23,6 +23,12 @@
>  		stdout-path = &uart0;
>  	};
>  
> +	aliases {
> +		ethernet0 = &eth0;
> +		ethernet1 = &eth1;
> +		ethernet2 = &eth2;
> +	};
> +
>  	memory {
>  		device_type = "memory";
>  		reg = <0x00000000 0x40000000>; /* 1024 MB */
> -- 
> 2.20.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases

Posted by Pali Rohár 3 years, 6 months ago

PING?

On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> This allows bootloader to correctly pass MAC addresses used by bootloader
> to individual interfaces into kernel device tree.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
>  arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f4eb6898aa6b..d2afa466e29a 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -23,6 +23,12 @@
>  		stdout-path = &uart0;
>  	};
>  
> +	aliases {
> +		ethernet0 = &eth0;
> +		ethernet1 = &eth1;
> +		ethernet2 = &eth2;
> +	};
> +
>  	memory {
>  		device_type = "memory";
>  		reg = <0x00000000 0x40000000>; /* 1024 MB */
> -- 
> 2.20.1
>

Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases

Posted by Pali Rohár 3 years, 6 months ago

Gregory: PING?

On Saturday 24 September 2022 14:13:02 Pali Rohár wrote:
> PING?
> 
> On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> > This allows bootloader to correctly pass MAC addresses used by bootloader
> > to individual interfaces into kernel device tree.
> > 
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> >  arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > index f4eb6898aa6b..d2afa466e29a 100644
> > --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > @@ -23,6 +23,12 @@
> >  		stdout-path = &uart0;
> >  	};
> >  
> > +	aliases {
> > +		ethernet0 = &eth0;
> > +		ethernet1 = &eth1;
> > +		ethernet2 = &eth2;
> > +	};
> > +
> >  	memory {
> >  		device_type = "memory";
> >  		reg = <0x00000000 0x40000000>; /* 1024 MB */
> > -- 
> > 2.20.1
> >

Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases

Posted by Pali Rohár 3 years, 5 months ago

PING?

On Sunday 09 October 2022 13:46:59 Pali Rohár wrote:
> Gregory: PING?
> 
> On Saturday 24 September 2022 14:13:02 Pali Rohár wrote:
> > PING?
> > 
> > On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> > > This allows bootloader to correctly pass MAC addresses used by bootloader
> > > to individual interfaces into kernel device tree.
> > > 
> > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > ---
> > >  arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > > index f4eb6898aa6b..d2afa466e29a 100644
> > > --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > > +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > > @@ -23,6 +23,12 @@
> > >  		stdout-path = &uart0;
> > >  	};
> > >  
> > > +	aliases {
> > > +		ethernet0 = &eth0;
> > > +		ethernet1 = &eth1;
> > > +		ethernet2 = &eth2;
> > > +	};
> > > +
> > >  	memory {
> > >  		device_type = "memory";
> > >  		reg = <0x00000000 0x40000000>; /* 1024 MB */
> > > -- 
> > > 2.20.1
> > >

Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases

Posted by Pali Rohár 3 years, 8 months ago

On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> This allows bootloader to correctly pass MAC addresses used by bootloader
> to individual interfaces into kernel device tree.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---

Maybe this should have Fixes line?

Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")

>  arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f4eb6898aa6b..d2afa466e29a 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -23,6 +23,12 @@
>  		stdout-path = &uart0;
>  	};
>  
> +	aliases {
> +		ethernet0 = &eth0;
> +		ethernet1 = &eth1;
> +		ethernet2 = &eth2;
> +	};
> +
>  	memory {
>  		device_type = "memory";
>  		reg = <0x00000000 0x40000000>; /* 1024 MB */
> -- 
> 2.20.1
>

Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases

Posted by Andrew Lunn 3 years, 8 months ago

On Wed, Jul 27, 2022 at 03:15:04PM +0200, Pali Rohár wrote:
> On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> > This allows bootloader to correctly pass MAC addresses used by bootloader
> > to individual interfaces into kernel device tree.
> > 
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> 
> Maybe this should have Fixes line?
> 
> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")

Is it broken with older kernels? That is a big part of Fixes: to
indicate it needs back porting. Is this a new u-boot feature?

	 Andrew

Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases

Posted by Pali Rohár 3 years, 8 months ago

On Tuesday 09 August 2022 22:28:51 Andrew Lunn wrote:
> On Wed, Jul 27, 2022 at 03:15:04PM +0200, Pali Rohár wrote:
> > On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> > > This allows bootloader to correctly pass MAC addresses used by bootloader
> > > to individual interfaces into kernel device tree.
> > > 
> > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > ---
> > 
> > Maybe this should have Fixes line?
> > 
> > Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> 
> Is it broken with older kernels? That is a big part of Fixes: to
> indicate it needs back porting. Is this a new u-boot feature?
> 
> 	 Andrew

This is old u-boot feature. I was investigating why u-boot is not able
to correctly modify loaded omnia dtb file when booting linux kernel and
I found out that it is because it cannot due to missing ethernet
aliases.

Also there is a new u-boot feature for omnia to correctly put
phy-reset-gpios property into eth 2 node based on board hw revision. So
this is another purpose for which we should have those aliases, to allow
kernel to correctly reset wan (eth 2) PHY.

I would suggest this change for backporting into stable.