[v6] Add ums512 clocks and relative bindings file

[PATCH V6 0/2] Add ums512 clocks and relative bindings file

Cixi Geng posted 2 patches 3 years, 8 months ago

Diff against v1 v2 v3 v4 v5 v7 v8 v8
Download series mbox

There is a newer version of this series

.../bindings/mfd/sprd,ums512-glbreg.yaml      |   68 +
drivers/clk/sprd/Kconfig                      |    6 +
drivers/clk/sprd/Makefile                     |    1 +
drivers/clk/sprd/ums512-clk.c                 | 2202 +++++++++++++++++
4 files changed, 2277 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml
create mode 100644 drivers/clk/sprd/ums512-clk.c

Expand all Fold all

[PATCH V6 0/2] Add ums512 clocks and relative bindings file

Posted by Cixi Geng 3 years, 8 months ago

From: Cixi Geng <cixi.geng1@unisoc.com>

This patchset is add the UMS512 clocks support

v2 changes:
  adjust description and add the "sprd,ums512-glbregs,syscon,simple-mfd"
  compatibles to fix match failed logs in the dt_binding_check.
  add the property license and copyright notice.

v3 changes:
  fix wrong indentation and hint: "maxItems" is not needed with an "items"
  list when use the latest dtschema.

v4 changes:
  move the syscon bindins from clk to glbreg yaml file by pickup 
  chunyan's patch for global registers bindings
  fix the comments from Krzysztof in v3 patchset
  add the Acked-by: Krzysztof in patch v4 3/4
  fix the  warning Prefer "GPL" over "GPL v2"

v5 changes:
  Add review tags.
  fix the comments in ums512-glbreg.yaml.

v6 changes:
  No more send the patch 1/4 and 3/4 in V5 for applied by Stephen
  change GPL to GPL v2 license
  fix the lack of space in some "{" and "}"
  add check error for sprd_clk_regmap_init.

Chunyan Zhang (1):
  dt-bindings: mfd: sprd: Add bindings for ums512 global registers

Cixi Geng (1):
  clk: sprd: Add clocks support for UMS512

 .../bindings/mfd/sprd,ums512-glbreg.yaml      |   68 +
 drivers/clk/sprd/Kconfig                      |    6 +
 drivers/clk/sprd/Makefile                     |    1 +
 drivers/clk/sprd/ums512-clk.c                 | 2202 +++++++++++++++++
 4 files changed, 2277 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml
 create mode 100644 drivers/clk/sprd/ums512-clk.c

-- 
2.25.1

Re: [PATCH V6 0/2] Add ums512 clocks and relative bindings file

Posted by Krzysztof Kozlowski 3 years, 8 months ago

On 26/07/2022 12:24, Cixi Geng wrote:
> From: Cixi Geng <cixi.geng1@unisoc.com>
> 
> This patchset is add the UMS512 clocks support
> 
> v2 changes:
>   adjust description and add the "sprd,ums512-glbregs,syscon,simple-mfd"
>   compatibles to fix match failed logs in the dt_binding_check.
>   add the property license and copyright notice.
> 
> v3 changes:
>   fix wrong indentation and hint: "maxItems" is not needed with an "items"
>   list when use the latest dtschema.
> 
> v4 changes:
>   move the syscon bindins from clk to glbreg yaml file by pickup 
>   chunyan's patch for global registers bindings
>   fix the comments from Krzysztof in v3 patchset
>   add the Acked-by: Krzysztof in patch v4 3/4
>   fix the  warning Prefer "GPL" over "GPL v2"
> 
> v5 changes:
>   Add review tags.
>   fix the comments in ums512-glbreg.yaml.
> 
> v6 changes:
>   No more send the patch 1/4 and 3/4 in V5 for applied by Stephen
>   change GPL to GPL v2 license
>   fix the lack of space in some "{" and "}"
>   add check error for sprd_clk_regmap_init.

That's not good. That was a dependency here (for MFD bindings). You must
describe the dependencies in cover letter so maintainers know how to do it.

Your MFD patch is not applicable now...


Best regards,
Krzysztof