arm64: dts: arm: juno: Remove legacy Coresight 'slave-mode' property

[PATCH] arm64: dts: arm: juno: Remove legacy Coresight 'slave-mode' property

Posted by Rob Herring 3 years, 8 months ago

The 'slave-mode' property is not valid under 'in-ports' as it was the
legacy way to find input ports. Warnings are generated from the Coresight
schema:

arch/arm64/boot/dts/arm/juno-r1.dtb: funnel@20150000: in-ports:port@0:endpoint: Unevaluated properties are not allowed ('slave-mode' was unexpected)
        From schema: Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml

Signed-off-by: Rob Herring <robh@kernel.org>
---
 arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi b/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
index 2e43f4531308..fbcdf63ad56d 100644
--- a/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
@@ -67,7 +67,6 @@ in-ports {
 			port@0 {
 				reg = <0>;
 				csys2_funnel_in_port0: endpoint {
-					slave-mode;
 					remote-endpoint = <&etf0_out_port>;
 				};
 			};
@@ -75,7 +74,6 @@ csys2_funnel_in_port0: endpoint {
 			port@1 {
 				reg = <1>;
 				csys2_funnel_in_port1: endpoint {
-					slave-mode;
 					remote-endpoint = <&etf1_out_port>;
 				};
 			};
-- 
2.34.1

Re: [PATCH] arm64: dts: arm: juno: Remove legacy Coresight 'slave-mode' property

Posted by Sudeep Holla 3 years, 8 months ago

On Thu, 21 Jul 2022 15:29:52 -0600, Rob Herring wrote:
> The 'slave-mode' property is not valid under 'in-ports' as it was the
> legacy way to find input ports. Warnings are generated from the Coresight
> schema:
> 
> arch/arm64/boot/dts/arm/juno-r1.dtb: funnel@20150000: in-ports:port@0:endpoint: Unevaluated properties are not allowed ('slave-mode' was unexpected)
>         From schema: Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
> 
> [...]

Applied to sudeep.holla/linux (for-next/juno), thanks!

[1/1] arm64: dts: arm: juno: Remove legacy Coresight 'slave-mode' property
      https://git.kernel.org/sudeep.holla/c/2a9eb57e20e6

--
Regards,
Sudeep

Re: [PATCH] arm64: dts: arm: juno: Remove legacy Coresight 'slave-mode' property

Posted by Suzuki K Poulose 3 years, 8 months ago

On 21/07/2022 22:29, Rob Herring wrote:
> The 'slave-mode' property is not valid under 'in-ports' as it was the
> legacy way to find input ports. Warnings are generated from the Coresight
> schema:
> 
> arch/arm64/boot/dts/arm/juno-r1.dtb: funnel@20150000: in-ports:port@0:endpoint: Unevaluated properties are not allowed ('slave-mode' was unexpected)
>          From schema: Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>   arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi b/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
> index 2e43f4531308..fbcdf63ad56d 100644
> --- a/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
> +++ b/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi
> @@ -67,7 +67,6 @@ in-ports {
>   			port@0 {
>   				reg = <0>;
>   				csys2_funnel_in_port0: endpoint {
> -					slave-mode;
>   					remote-endpoint = <&etf0_out_port>;
>   				};
>   			};
> @@ -75,7 +74,6 @@ csys2_funnel_in_port0: endpoint {
>   			port@1 {
>   				reg = <1>;
>   				csys2_funnel_in_port1: endpoint {
> -					slave-mode;
>   					remote-endpoint = <&etf1_out_port>;
>   				};
>   			};



Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>