media: staging: media: zoran: Fixed Block comments

[PATCH] media: staging: media: zoran: Fixed Block comments

Posted by Abhijeet Srivastava 3 years, 9 months ago

Warning found by checkpatch.pl script.

Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
---
 drivers/staging/media/zoran/zoran_driver.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c
index 4304b7e21709..b408c1d4e0a7 100644
--- a/drivers/staging/media/zoran/zoran_driver.c
+++ b/drivers/staging/media/zoran/zoran_driver.c
@@ -746,9 +746,11 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
 	.vidioc_enum_input		    = zoran_enum_input,
 	.vidioc_g_input			    = zoran_g_input,
 	.vidioc_s_input			    = zoran_s_input,
+
 /*	.vidioc_enum_output		    = zoran_enum_output,
-	.vidioc_g_output		    = zoran_g_output,
-	.vidioc_s_output		    = zoran_s_output,*/
+ *	.vidioc_g_output		    = zoran_g_output,
+ *	.vidioc_s_output		    = zoran_s_output,
+ */
 	.vidioc_g_std			    = zoran_g_std,
 	.vidioc_s_std			    = zoran_s_std,
 	.vidioc_create_bufs		    = vb2_ioctl_create_bufs,
-- 
2.34.1

Re: [PATCH] media: staging: media: zoran: Fixed Block comments

Posted by Dan Carpenter 3 years, 8 months ago

On Thu, Jul 21, 2022 at 11:07:22PM +0530, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script.
> 
> Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
> ---
>  drivers/staging/media/zoran/zoran_driver.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c
> index 4304b7e21709..b408c1d4e0a7 100644
> --- a/drivers/staging/media/zoran/zoran_driver.c
> +++ b/drivers/staging/media/zoran/zoran_driver.c
> @@ -746,9 +746,11 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
>  	.vidioc_enum_input		    = zoran_enum_input,
>  	.vidioc_g_input			    = zoran_g_input,
>  	.vidioc_s_input			    = zoran_s_input,
> +
>  /*	.vidioc_enum_output		    = zoran_enum_output,
> -	.vidioc_g_output		    = zoran_g_output,
> -	.vidioc_s_output		    = zoran_s_output,*/
> + *	.vidioc_g_output		    = zoran_g_output,
> + *	.vidioc_s_output		    = zoran_s_output,
> + */

Always, just delete dead code.

regards,
dan carpenter