[PATCH] kconfig: Qt5: tell the user which packages are required

Randy Dunlap posted 1 patch 3 years, 9 months ago
scripts/kconfig/qconf-cfg.sh |    1 +
1 file changed, 1 insertion(+)
[PATCH] kconfig: Qt5: tell the user which packages are required
Posted by Randy Dunlap 3 years, 9 months ago
Along with saying "Please install Qt5 ...", tell exactly which
parts of Qt5 are needed. This is useful when parts of Qt5 are
installed but some of the required pieces are missing, and it
eliminates the need for the user to find the shell script and
the line in it that provide that information.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org
---
 scripts/kconfig/qconf-cfg.sh |    1 +
 1 file changed, 1 insertion(+)

--- a/scripts/kconfig/qconf-cfg.sh
+++ b/scripts/kconfig/qconf-cfg.sh
@@ -20,5 +20,6 @@ fi
 echo >&2 "*"
 echo >&2 "* Could not find Qt5 via ${HOSTPKG_CONFIG}."
 echo >&2 "* Please install Qt5 and make sure it's in PKG_CONFIG_PATH"
+echo >&2 "* You need $PKG"
 echo >&2 "*"
 exit 1
Re: [PATCH] kconfig: Qt5: tell the user which packages are required
Posted by Masahiro Yamada 3 years, 8 months ago
On Thu, Jul 21, 2022 at 2:38 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Along with saying "Please install Qt5 ...", tell exactly which
> parts of Qt5 are needed. This is useful when parts of Qt5 are
> installed but some of the required pieces are missing, and it
> eliminates the need for the user to find the shell script and
> the line in it that provide that information.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: linux-kbuild@vger.kernel.org

Applied to linux-kbuild.
Thanks.

> ---
>  scripts/kconfig/qconf-cfg.sh |    1 +
>  1 file changed, 1 insertion(+)
>
> --- a/scripts/kconfig/qconf-cfg.sh
> +++ b/scripts/kconfig/qconf-cfg.sh
> @@ -20,5 +20,6 @@ fi
>  echo >&2 "*"
>  echo >&2 "* Could not find Qt5 via ${HOSTPKG_CONFIG}."
>  echo >&2 "* Please install Qt5 and make sure it's in PKG_CONFIG_PATH"
> +echo >&2 "* You need $PKG"
>  echo >&2 "*"
>  exit 1



-- 
Best Regards
Masahiro Yamada