[PATCH RESEND] dt-bindings: leds: qcom-wled: fix number of addresses

Krzysztof Kozlowski posted 1 patch 3 years, 9 months ago
.../devicetree/bindings/leds/backlight/qcom-wled.yaml    | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
[PATCH RESEND] dt-bindings: leds: qcom-wled: fix number of addresses
Posted by Krzysztof Kozlowski 3 years, 9 months ago
On PM660L, PMI8994 and PMI8998, the WLED has two address spaces.  This
also fixes dtbs_check warnings like:

  arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dtb: leds@d800: reg: [[55296], [55552]] is too long

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/leds/backlight/qcom-wled.yaml    | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
index 5d66c3e4def5..4c15693f7a01 100644
--- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
+++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
@@ -26,7 +26,8 @@ properties:
       - qcom,pm8150l-wled
 
   reg:
-    maxItems: 1
+    minItems: 1
+    maxItems: 2
 
   default-brightness:
     description: |
@@ -171,6 +172,9 @@ allOf:
 
     then:
       properties:
+        reg:
+          maxItems: 1
+
         qcom,current-boost-limit:
           enum: [ 105, 385, 525, 805, 980, 1260, 1400, 1680 ]
           default: 805
@@ -189,6 +193,9 @@ allOf:
 
     else:
       properties:
+        reg:
+          minItems: 2
+
         qcom,current-boost-limit:
           enum: [ 105, 280, 450, 620, 970, 1150, 1300, 1500 ]
           default: 970
-- 
2.34.1
Re: [PATCH RESEND] dt-bindings: leds: qcom-wled: fix number of addresses
Posted by Krzysztof Kozlowski 3 years, 7 months ago
On 20/07/2022 19:37, Krzysztof Kozlowski wrote:
> On PM660L, PMI8994 and PMI8998, the WLED has two address spaces.  This
> also fixes dtbs_check warnings like:
> 
>   arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dtb: leds@d800: reg: [[55296], [55552]] is too long
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/leds/backlight/qcom-wled.yaml    | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)


The resent was a month ago. I assume this won't go via LEDs tree, so I
will resend (again) without Rob's review, so it could go via Rob's tree.

Best regards,
Krzysztof
Re: [PATCH RESEND] dt-bindings: leds: qcom-wled: fix number of addresses
Posted by Lee Jones 3 years, 7 months ago
On Thu, 25 Aug 2022, Krzysztof Kozlowski wrote:

> On 20/07/2022 19:37, Krzysztof Kozlowski wrote:
> > On PM660L, PMI8994 and PMI8998, the WLED has two address spaces.  This
> > also fixes dtbs_check warnings like:
> > 
> >   arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dtb: leds@d800: reg: [[55296], [55552]] is too long
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> >  .../devicetree/bindings/leds/backlight/qcom-wled.yaml    | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> 
> The resent was a month ago. I assume this won't go via LEDs tree, so I
> will resend (again) without Rob's review, so it could go via Rob's tree.

If you have not already done so, please resend this and Cc my
kernel.org address, as per MAINTAINERS.  Thanks Krzysztof.

-- 
DEPRECATED: Please use lee@kernel.org
Re: [PATCH RESEND] dt-bindings: leds: qcom-wled: fix number of addresses
Posted by Krzysztof Kozlowski 3 years, 7 months ago
On 05/09/2022 15:56, Lee Jones wrote:
> On Thu, 25 Aug 2022, Krzysztof Kozlowski wrote:
> 
>> On 20/07/2022 19:37, Krzysztof Kozlowski wrote:
>>> On PM660L, PMI8994 and PMI8998, the WLED has two address spaces.  This
>>> also fixes dtbs_check warnings like:
>>>
>>>   arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dtb: leds@d800: reg: [[55296], [55552]] is too long
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>> ---
>>>  .../devicetree/bindings/leds/backlight/qcom-wled.yaml    | 9 ++++++++-
>>>  1 file changed, 8 insertions(+), 1 deletion(-)
>>
>>
>> The resent was a month ago. I assume this won't go via LEDs tree, so I
>> will resend (again) without Rob's review, so it could go via Rob's tree.
> 
> If you have not already done so, please resend this and Cc my
> kernel.org address, as per MAINTAINERS.  Thanks Krzysztof.
> 

Thanks, I resent and Rob already took it.

Best regards,
Krzysztof