[v3] drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710 SoC

[PATCH v3 0/3] drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710 SoC

Posted by Shuai Xue 3 years, 9 months ago

This patchset adds support for Yitian 710 DDR Sub-System Driveway PMU driver,
which custom-built by Alibaba Group's chip development business, T-Head.

Changes since v2:
- relaxe build constraints and add COMPILE_TEST
- explicitly include dependent headers
- add Reviewed-by, thanks Jonathan Cameron and Randy Dunlap for their valuable review and comments
- Link: https://lore.kernel.org/linux-arm-kernel/20220715151310.90091-4-xueshuai@linux.alibaba.com/T/#m1116abc4b0bda1943ab436a45d95359f9bbe0858

Changes since v1:
- add high level workflow about DDRC so that user cloud better understand the
  PMU hardware mechanism
- rewrite patch description and add interrupt sharing constraints
- delete event perf prefix
- add a condition to fix bug in ali_drw_pmu_isr
- perfer CPU in the same Node when migrating irq
- use FIELD_PREP and FIELD_GET to make code more readable
- add T-Head HID and leave ARMHD700 as CID for compatibility
- Link: https://lore.kernel.org/linux-arm-kernel/eb50310d-d4a0-c7ff-7f1c-b4ffd919b10c@linux.alibaba.com/T/

Shuai Xue (3):
  docs: perf: Add description for Alibaba's T-Head PMU driver
  drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710
    SoC
  MAINTAINERS: add maintainers for Alibaba' T-Head PMU driver

 .../admin-guide/perf/alibaba_pmu.rst          | 100 +++
 Documentation/admin-guide/perf/index.rst      |   1 +
 MAINTAINERS                                   |   7 +
 drivers/perf/Kconfig                          |   7 +
 drivers/perf/Makefile                         |   1 +
 drivers/perf/alibaba_uncore_drw_pmu.c         | 810 ++++++++++++++++++
 6 files changed, 926 insertions(+)
 create mode 100644 Documentation/admin-guide/perf/alibaba_pmu.rst
 create mode 100644 drivers/perf/alibaba_uncore_drw_pmu.c

-- 
2.20.1.9.gb50a0d7

Re: [PATCH v3 0/3] drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710 SoC

Posted by Baolin Wang 3 years, 8 months ago


On 7/20/2022 2:58 PM, Shuai Xue wrote:
> This patchset adds support for Yitian 710 DDR Sub-System Driveway PMU driver,
> which custom-built by Alibaba Group's chip development business, T-Head.
> 
> Changes since v2:
> - relaxe build constraints and add COMPILE_TEST
> - explicitly include dependent headers
> - add Reviewed-by, thanks Jonathan Cameron and Randy Dunlap for their valuable review and comments
> - Link: https://lore.kernel.org/linux-arm-kernel/20220715151310.90091-4-xueshuai@linux.alibaba.com/T/#m1116abc4b0bda1943ab436a45d95359f9bbe0858
> 
> Changes since v1:
> - add high level workflow about DDRC so that user cloud better understand the
>    PMU hardware mechanism
> - rewrite patch description and add interrupt sharing constraints
> - delete event perf prefix
> - add a condition to fix bug in ali_drw_pmu_isr
> - perfer CPU in the same Node when migrating irq
> - use FIELD_PREP and FIELD_GET to make code more readable
> - add T-Head HID and leave ARMHD700 as CID for compatibility
> - Link: https://lore.kernel.org/linux-arm-kernel/eb50310d-d4a0-c7ff-7f1c-b4ffd919b10c@linux.alibaba.com/T/
> 

As I've reviewed the patch set internally before, please feel free to add:
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

> Shuai Xue (3):
>    docs: perf: Add description for Alibaba's T-Head PMU driver
>    drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710
>      SoC
>    MAINTAINERS: add maintainers for Alibaba' T-Head PMU driver
> 
>   .../admin-guide/perf/alibaba_pmu.rst          | 100 +++
>   Documentation/admin-guide/perf/index.rst      |   1 +
>   MAINTAINERS                                   |   7 +
>   drivers/perf/Kconfig                          |   7 +
>   drivers/perf/Makefile                         |   1 +
>   drivers/perf/alibaba_uncore_drw_pmu.c         | 810 ++++++++++++++++++
>   6 files changed, 926 insertions(+)
>   create mode 100644 Documentation/admin-guide/perf/alibaba_pmu.rst
>   create mode 100644 drivers/perf/alibaba_uncore_drw_pmu.c
>

Re: [PATCH v3 0/3] drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710 SoC

Posted by Shuai Xue 3 years, 8 months ago


在 2022/8/17 PM4:15, Baolin Wang 写道:
> 
> 
> On 7/20/2022 2:58 PM, Shuai Xue wrote:
>> This patchset adds support for Yitian 710 DDR Sub-System Driveway PMU driver,
>> which custom-built by Alibaba Group's chip development business, T-Head.
>>
>> Changes since v2:
>> - relaxe build constraints and add COMPILE_TEST
>> - explicitly include dependent headers
>> - add Reviewed-by, thanks Jonathan Cameron and Randy Dunlap for their valuable review and comments
>> - Link: https://lore.kernel.org/linux-arm-kernel/20220715151310.90091-4-xueshuai@linux.alibaba.com/T/#m1116abc4b0bda1943ab436a45d95359f9bbe0858
>>
>> Changes since v1:
>> - add high level workflow about DDRC so that user cloud better understand the
>>    PMU hardware mechanism
>> - rewrite patch description and add interrupt sharing constraints
>> - delete event perf prefix
>> - add a condition to fix bug in ali_drw_pmu_isr
>> - perfer CPU in the same Node when migrating irq
>> - use FIELD_PREP and FIELD_GET to make code more readable
>> - add T-Head HID and leave ARMHD700 as CID for compatibility
>> - Link: https://lore.kernel.org/linux-arm-kernel/eb50310d-d4a0-c7ff-7f1c-b4ffd919b10c@linux.alibaba.com/T/
>>
> 
> As I've reviewed the patch set internally before, please feel free to add:
> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

Thank you. :) I will add your Reviewed-by in next version.

Best Regards,
Shuai

> 
>> Shuai Xue (3):
>>    docs: perf: Add description for Alibaba's T-Head PMU driver
>>    drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710
>>      SoC
>>    MAINTAINERS: add maintainers for Alibaba' T-Head PMU driver
>>
>>   .../admin-guide/perf/alibaba_pmu.rst          | 100 +++
>>   Documentation/admin-guide/perf/index.rst      |   1 +
>>   MAINTAINERS                                   |   7 +
>>   drivers/perf/Kconfig                          |   7 +
>>   drivers/perf/Makefile                         |   1 +
>>   drivers/perf/alibaba_uncore_drw_pmu.c         | 810 ++++++++++++++++++
>>   6 files changed, 926 insertions(+)
>>   create mode 100644 Documentation/admin-guide/perf/alibaba_pmu.rst
>>   create mode 100644 drivers/perf/alibaba_uncore_drw_pmu.c
>>

Re: [PATCH v3 0/3] drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710 SoC

Posted by Shuai Xue 3 years, 8 months ago

Hi, Will,

I was wondering that do you have any comments to this patch set?

Thank you.

Best Regards,
Shuai

在 2022/7/20 PM2:58, Shuai Xue 写道:
> This patchset adds support for Yitian 710 DDR Sub-System Driveway PMU driver,
> which custom-built by Alibaba Group's chip development business, T-Head.
> 
> Changes since v2:
> - relaxe build constraints and add COMPILE_TEST
> - explicitly include dependent headers
> - add Reviewed-by, thanks Jonathan Cameron and Randy Dunlap for their valuable review and comments
> - Link: https://lore.kernel.org/linux-arm-kernel/20220715151310.90091-4-xueshuai@linux.alibaba.com/T/#m1116abc4b0bda1943ab436a45d95359f9bbe0858
> 
> Changes since v1:
> - add high level workflow about DDRC so that user cloud better understand the
>   PMU hardware mechanism
> - rewrite patch description and add interrupt sharing constraints
> - delete event perf prefix
> - add a condition to fix bug in ali_drw_pmu_isr
> - perfer CPU in the same Node when migrating irq
> - use FIELD_PREP and FIELD_GET to make code more readable
> - add T-Head HID and leave ARMHD700 as CID for compatibility
> - Link: https://lore.kernel.org/linux-arm-kernel/eb50310d-d4a0-c7ff-7f1c-b4ffd919b10c@linux.alibaba.com/T/
> 
> Shuai Xue (3):
>   docs: perf: Add description for Alibaba's T-Head PMU driver
>   drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710
>     SoC
>   MAINTAINERS: add maintainers for Alibaba' T-Head PMU driver
> 
>  .../admin-guide/perf/alibaba_pmu.rst          | 100 +++
>  Documentation/admin-guide/perf/index.rst      |   1 +
>  MAINTAINERS                                   |   7 +
>  drivers/perf/Kconfig                          |   7 +
>  drivers/perf/Makefile                         |   1 +
>  drivers/perf/alibaba_uncore_drw_pmu.c         | 810 ++++++++++++++++++
>  6 files changed, 926 insertions(+)
>  create mode 100644 Documentation/admin-guide/perf/alibaba_pmu.rst
>  create mode 100644 drivers/perf/alibaba_uncore_drw_pmu.c
>