[v1] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade

[PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade

Posted by Yunlong Jia 3 years, 9 months ago

SKU6 is LTE(w/o eSIM)+WIFI+Parade

Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
---

 arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
index 764c451c1a857..4649eaec6318d 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
@@ -14,7 +14,7 @@
 
 / {
 	model = "Google Pazquel (Parade,LTE)";
-	compatible = "google,pazquel-sku4", "qcom,sc7180";
+	compatible = "google,pazquel-sku4", "google,pazquel-sku6", "qcom,sc7180";
 };
 
 &ap_sar_sensor_i2c {
-- 
2.17.1

Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade

Posted by Krzysztof Kozlowski 3 years, 9 months ago

On 20/07/2022 04:51, Yunlong Jia wrote:
> SKU6 is LTE(w/o eSIM)+WIFI+Parade
> 
> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
> ---
> 
>  arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> index 764c451c1a857..4649eaec6318d 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> @@ -14,7 +14,7 @@
>  
>  / {
>  	model = "Google Pazquel (Parade,LTE)";
> -	compatible = "google,pazquel-sku4", "qcom,sc7180";
> +	compatible = "google,pazquel-sku4", "google,pazquel-sku6", "qcom,sc7180";

You miss binding change and sku6 should be rather added before sku4 as
it is more specific, isn't it?


Best regards,
Krzysztof

Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade

Posted by Doug Anderson 3 years, 9 months ago

Hi,

On Tue, Jul 19, 2022 at 11:10 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 20/07/2022 04:51, Yunlong Jia wrote:
> > SKU6 is LTE(w/o eSIM)+WIFI+Parade
> >
> > Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
> > ---
> >
> >  arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> > index 764c451c1a857..4649eaec6318d 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> > @@ -14,7 +14,7 @@
> >
> >  / {
> >       model = "Google Pazquel (Parade,LTE)";
> > -     compatible = "google,pazquel-sku4", "qcom,sc7180";
> > +     compatible = "google,pazquel-sku4", "google,pazquel-sku6", "qcom,sc7180";
>
> You miss binding change and sku6 should be rather added before sku4 as
> it is more specific, isn't it?

Just to close the loop: the order doesn't matter at all. Neither sku4
nor sku6 is "more specific". One has the eSIM stuffed and one doesn't.
I don't personally care about what order these are listed in, though,
so if Krzysztof is happier with "sku6" being first then I'm OK w/ it
as long as it matches the bindings.

-Doug

Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade

Posted by Krzysztof Kozlowski 3 years, 9 months ago

On 20/07/2022 17:13, Doug Anderson wrote:
> Hi,
> 
> On Tue, Jul 19, 2022 at 11:10 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 20/07/2022 04:51, Yunlong Jia wrote:
>>> SKU6 is LTE(w/o eSIM)+WIFI+Parade
>>>
>>> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
>>> ---
>>>
>>>  arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
>>> index 764c451c1a857..4649eaec6318d 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
>>> @@ -14,7 +14,7 @@
>>>
>>>  / {
>>>       model = "Google Pazquel (Parade,LTE)";
>>> -     compatible = "google,pazquel-sku4", "qcom,sc7180";
>>> +     compatible = "google,pazquel-sku4", "google,pazquel-sku6", "qcom,sc7180";
>>
>> You miss binding change and sku6 should be rather added before sku4 as
>> it is more specific, isn't it?
> 
> Just to close the loop: the order doesn't matter at all. Neither sku4
> nor sku6 is "more specific". One has the eSIM stuffed and one doesn't.

Thanks Doug. Then the commit description could be improved, so reviewer
does not have to ask such questions. Otherwise it is confusing to see a
board which says it is for LTE version but it is actually not for LTE
version (or whatever combination you have).

Best regards,
Krzysztof

Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade

Posted by Doug Anderson 3 years, 9 months ago

Hi,

On Wed, Jul 20, 2022 at 9:55 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 20/07/2022 17:13, Doug Anderson wrote:
> > Hi,
> >
> > On Tue, Jul 19, 2022 at 11:10 PM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 20/07/2022 04:51, Yunlong Jia wrote:
> >>> SKU6 is LTE(w/o eSIM)+WIFI+Parade
> >>>
> >>> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
> >>> ---
> >>>
> >>>  arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> >>> index 764c451c1a857..4649eaec6318d 100644
> >>> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> >>> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> >>> @@ -14,7 +14,7 @@
> >>>
> >>>  / {
> >>>       model = "Google Pazquel (Parade,LTE)";
> >>> -     compatible = "google,pazquel-sku4", "qcom,sc7180";
> >>> +     compatible = "google,pazquel-sku4", "google,pazquel-sku6", "qcom,sc7180";
> >>
> >> You miss binding change and sku6 should be rather added before sku4 as
> >> it is more specific, isn't it?
> >
> > Just to close the loop: the order doesn't matter at all. Neither sku4
> > nor sku6 is "more specific". One has the eSIM stuffed and one doesn't.
>
> Thanks Doug. Then the commit description could be improved, so reviewer
> does not have to ask such questions. Otherwise it is confusing to see a
> board which says it is for LTE version but it is actually not for LTE
> version (or whatever combination you have).

Yeah. I guess it makes more sense with the background knowledge that
the different SKUs are:

LTE with physical SIM _and_ eSIM
LTE with only a physical SIM
WiFi only

...so both sku4 and sku6 are LTE SKUs. One has the eSIM stuffed and
one doesn't. There is a single shared device tree for the two.

-Doug

Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade

Posted by Krzysztof Kozlowski 3 years, 9 months ago

On 20/07/2022 19:53, Doug Anderson wrote:
> 
> Yeah. I guess it makes more sense with the background knowledge that
> the different SKUs are:
> 
> LTE with physical SIM _and_ eSIM
> LTE with only a physical SIM
> WiFi only
> 
> ...so both sku4 and sku6 are LTE SKUs. One has the eSIM stuffed and
> one doesn't. There is a single shared device tree for the two.

Above in commit msg would solve all my questions, I guess. :)


Best regards,
Krzysztof