Date:do not initialise statics to 0

[PATCH] Date:do not initialise statics to 0

Posted by Xin Gao 3 years, 9 months ago

do not initialise statics to 0

Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
---
 drivers/ata/pata_artop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/pata_artop.c b/drivers/ata/pata_artop.c
index 20a8f31a3f57..1aad8df2ea87 100644
--- a/drivers/ata/pata_artop.c
+++ b/drivers/ata/pata_artop.c
@@ -37,7 +37,7 @@
  *	test stuff.
  */
 
-static int clock = 0;
+static int clock;
 
 /**
  *	artop62x0_pre_reset	-	probe begin
-- 
2.30.2

Re: [PATCH] Date:do not initialise statics to 0

Posted by Damien Le Moal 3 years, 9 months ago

On 7/19/22 20:29, Xin Gao wrote:
> do not initialise statics to 0
> 
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
>  drivers/ata/pata_artop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_artop.c b/drivers/ata/pata_artop.c
> index 20a8f31a3f57..1aad8df2ea87 100644
> --- a/drivers/ata/pata_artop.c
> +++ b/drivers/ata/pata_artop.c
> @@ -37,7 +37,7 @@
>   *	test stuff.
>   */
>  
> -static int clock = 0;
> +static int clock;
>  
>  /**
>   *	artop62x0_pre_reset	-	probe begin

Very weird patch title.

Is this solving any static analyzer or compiler warning ? If not, this is
not a very useful change.

-- 
Damien Le Moal
Western Digital Research