crypto: inside-secure: Add missing MODULE_DEVICE_TABLE for of

[PATCH] crypto: inside-secure: Add missing MODULE_DEVICE_TABLE for of

Posted by Pali Rohár 3 years, 9 months ago

Without MODULE_DEVICE_TABLE, crypto_safexcel.ko module is not automatically
loaded on platforms where inside-secure crypto HW is specified in device
tree (e.g. Armada 3720). So add missing MODULE_DEVICE_TABLE for of.

Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Signed-off-by: Pali Rohár <pali@kernel.org>
---
 drivers/crypto/inside-secure/safexcel.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
index 9b1a158aec29..ad0d8c4a71ac 100644
--- a/drivers/crypto/inside-secure/safexcel.c
+++ b/drivers/crypto/inside-secure/safexcel.c
@@ -1831,6 +1831,8 @@ static const struct of_device_id safexcel_of_match_table[] = {
 	{},
 };
 
+MODULE_DEVICE_TABLE(of, safexcel_of_match_table);
+
 static struct platform_driver  crypto_safexcel = {
 	.probe		= safexcel_probe,
 	.remove		= safexcel_remove,
-- 
2.20.1

Re: [PATCH] crypto: inside-secure: Add missing MODULE_DEVICE_TABLE for of

Posted by Herbert Xu 3 years, 8 months ago

On Tue, Jul 19, 2022 at 09:54:03AM +0200, Pali Rohár wrote:
> Without MODULE_DEVICE_TABLE, crypto_safexcel.ko module is not automatically
> loaded on platforms where inside-secure crypto HW is specified in device
> tree (e.g. Armada 3720). So add missing MODULE_DEVICE_TABLE for of.
> 
> Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
>  drivers/crypto/inside-secure/safexcel.c | 2 ++
>  1 file changed, 2 insertions(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: inside-secure: Add missing MODULE_DEVICE_TABLE for of

Posted by Marek Behún 3 years, 9 months ago

On Tue, 19 Jul 2022 09:54:03 +0200
Pali Rohár <pali@kernel.org> wrote:

> Without MODULE_DEVICE_TABLE, crypto_safexcel.ko module is not automatically
> loaded on platforms where inside-secure crypto HW is specified in device
> tree (e.g. Armada 3720). So add missing MODULE_DEVICE_TABLE for of.
> 
> Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
> Signed-off-by: Pali Rohár <pali@kernel.org>

Acked-by: Marek Behún <kabel@kernel.org>