dt-bindings: leds: pwm-multicolor: document max-brigthness

[PATCH] dt-bindings: leds: pwm-multicolor: document max-brigthness

Posted by Krzysztof Kozlowski 3 years, 9 months ago

The Multicolor PWM LED uses max-brigthness property (in the example and
in the driver), so document it to fixi dt_binding_check warning like:

  leds/leds-pwm-multicolor.example.dtb:
    led-controller: multi-led: Unevaluated properties are not allowed ('max-brightness' was unexpected)

Reported-by: Rob Herring <robh@kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/leds/leds-pwm-multicolor.yaml       | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
index d0f846cd019d..bd6ec04a8727 100644
--- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
@@ -22,6 +22,12 @@ properties:
     $ref: leds-class-multicolor.yaml#
     unevaluatedProperties: false
 
+    properties:
+      max-brightness:
+        description:
+          Maximum brightness possible for the LED
+        $ref: /schemas/types.yaml#/definitions/uint32
+
     patternProperties:
       "^led-[0-9a-z]+$":
         type: object
-- 
2.34.1

Re: [PATCH] dt-bindings: leds: pwm-multicolor: document max-brigthness

Posted by Rob Herring 3 years, 9 months ago

On Tue, 19 Jul 2022 09:45:42 +0200, Krzysztof Kozlowski wrote:
> The Multicolor PWM LED uses max-brigthness property (in the example and
> in the driver), so document it to fixi dt_binding_check warning like:
> 
>   leds/leds-pwm-multicolor.example.dtb:
>     led-controller: multi-led: Unevaluated properties are not allowed ('max-brightness' was unexpected)
> 
> Reported-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/leds/leds-pwm-multicolor.yaml       | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH] dt-bindings: leds: pwm-multicolor: document max-brigthness

Posted by Pavel Machek 3 years, 8 months ago

On Tue 2022-07-19 17:26:14, Rob Herring wrote:
> On Tue, 19 Jul 2022 09:45:42 +0200, Krzysztof Kozlowski wrote:
> > The Multicolor PWM LED uses max-brigthness property (in the example and
> > in the driver), so document it to fixi dt_binding_check warning like:
> > 
> >   leds/leds-pwm-multicolor.example.dtb:
> >     led-controller: multi-led: Unevaluated properties are not allowed ('max-brightness' was unexpected)
> > 
> > Reported-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> >  .../devicetree/bindings/leds/leds-pwm-multicolor.yaml       | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Thank you, applied.
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.