drivers/gpu/drm/i915/selftests/i915_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Fix the double `wait' typo in comment.
Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
index c56a0c2cd2f7..ec05f578a698 100644
--- a/drivers/gpu/drm/i915/selftests/i915_request.c
+++ b/drivers/gpu/drm/i915/selftests/i915_request.c
@@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)
if (err)
goto err;
- /* Force the wait wait now to avoid including it in the benchmark */
+ /* Force the wait now to avoid including it in the benchmark */
err = i915_vma_sync(vma);
if (err)
goto err_pin;
--
2.35.1
Hi Jason,
On Sat, Jul 16, 2022 at 12:05:20PM +0800, Jason Wang wrote:
> Fix the double `wait' typo in comment.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
Few warnings for this patch:
1. you missed Rodrigo's r-b tag.
2. please add a counter to your patch, this would be [PATCH v2]
3. please add a changelog, as this is a single patch, do it
after the '---'
No need to resend, just keep the three notes in mind for your
next patches. Anyway, thanks for the fix and as I am at it:
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks,
Andi
> ---
> drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
> index c56a0c2cd2f7..ec05f578a698 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_request.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
> @@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)
> if (err)
> goto err;
>
> - /* Force the wait wait now to avoid including it in the benchmark */
> + /* Force the wait now to avoid including it in the benchmark */
> err = i915_vma_sync(vma);
> if (err)
> goto err_pin;
> --
> 2.35.1
> On Sat, Jul 16, 2022 at 12:05:20PM +0800, Jason Wang wrote: > > Fix the double `wait' typo in comment. > > > > Signed-off-by: Jason Wang <wangborong@cdjrlc.com> > > Few warnings for this patch: > > 1. you missed Rodrigo's r-b tag. > 2. please add a counter to your patch, this would be [PATCH v2] > 3. please add a changelog, as this is a single patch, do it > after the '---' > > No need to resend, just keep the three notes in mind for your > next patches. Anyway, thanks for the fix and as I am at it: > > Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Pushed in drm-intel-next. Thanks, Andi
On 16.07.2022 06:05, Jason Wang wrote: > Fix the double `wait' typo in comment. > > Signed-off-by: Jason Wang <wangborong@cdjrlc.com> > --- > drivers/gpu/drm/i915/selftests/i915_request.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c > index c56a0c2cd2f7..ec05f578a698 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_request.c > +++ b/drivers/gpu/drm/i915/selftests/i915_request.c > @@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915) > if (err) > goto err; > > - /* Force the wait wait now to avoid including it in the benchmark */ > + /* Force the wait now to avoid including it in the benchmark */ > err = i915_vma_sync(vma); > if (err) > goto err_pin; Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Regards Andrzej
On Wed, Jul 20, 2022 at 06:56:16PM +0200, Andrzej Hajda wrote: > On 16.07.2022 06:05, Jason Wang wrote: > > Fix the double `wait' typo in comment. > > > > Signed-off-by: Jason Wang <wangborong@cdjrlc.com> > > --- > > drivers/gpu/drm/i915/selftests/i915_request.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c > > index c56a0c2cd2f7..ec05f578a698 100644 > > --- a/drivers/gpu/drm/i915/selftests/i915_request.c > > +++ b/drivers/gpu/drm/i915/selftests/i915_request.c > > @@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915) > > if (err) > > goto err; > > - /* Force the wait wait now to avoid including it in the benchmark */ > > + /* Force the wait now to avoid including it in the benchmark */ > > err = i915_vma_sync(vma); > > if (err) > > goto err_pin; > > Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Thanks for the patch and review. Pushed to drm-intel-gt-next. > > Regards > Andrzej
© 2016 - 2026 Red Hat, Inc.