[PATCH] media: mc-request.c: Fix comment typo

Jason Wang posted 1 patch 3 years, 9 months ago
drivers/media/mc/mc-request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] media: mc-request.c: Fix comment typo
Posted by Jason Wang 3 years, 9 months ago
The double `that' is duplicated in line 162, remove one.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
 drivers/media/mc/mc-request.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/mc/mc-request.c b/drivers/media/mc/mc-request.c
index addb8f2d8939..752ea0bc804b 100644
--- a/drivers/media/mc/mc-request.c
+++ b/drivers/media/mc/mc-request.c
@@ -159,7 +159,7 @@ static long media_request_ioctl_queue(struct media_request *req)
 	 * state can only happen if either the driver changes the state or if
 	 * the user cancels the vb2 queue. The driver can only change the state
 	 * after each object is queued through the req_queue op (and note that
-	 * that op cannot fail), so setting the state to QUEUED up front is
+	 * op cannot fail), so setting the state to QUEUED up front is
 	 * safe.
 	 *
 	 * The other reason for changing the state is if the vb2 queue is
-- 
2.35.1
Re: [PATCH] media: mc-request.c: Fix comment typo
Posted by Sakari Ailus 3 years, 9 months ago
Hi Jason,

On Fri, Jul 15, 2022 at 01:16:46PM +0800, Jason Wang wrote:
> The double `that' is duplicated in line 162, remove one.
> 
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
>  drivers/media/mc/mc-request.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/mc/mc-request.c b/drivers/media/mc/mc-request.c
> index addb8f2d8939..752ea0bc804b 100644
> --- a/drivers/media/mc/mc-request.c
> +++ b/drivers/media/mc/mc-request.c
> @@ -159,7 +159,7 @@ static long media_request_ioctl_queue(struct media_request *req)
>  	 * state can only happen if either the driver changes the state or if
>  	 * the user cancels the vb2 queue. The driver can only change the state
>  	 * after each object is queued through the req_queue op (and note that
> -	 * that op cannot fail), so setting the state to QUEUED up front is

In this case, the second "that" is there for a reason.

> +	 * op cannot fail), so setting the state to QUEUED up front is
>  	 * safe.
>  	 *
>  	 * The other reason for changing the state is if the vb2 queue is

-- 
Sakari Ailus