.../bindings/input/nvidia,tegra20-kbc.txt | 55 --------- .../bindings/input/nvidia,tegra20-kbc.yaml | 109 ++++++++++++++++++ 2 files changed, 109 insertions(+), 55 deletions(-) delete mode 100644 Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.txt create mode 100644 Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.yaml
From: Max Buchholz <Max.Buchholz@gmx.de>
This converts the Nvidia Tegra keyboard controller bindings to YAML
and fix them up a bit.
Reviewed-by: David Heidelberg <david@ixit.cz>
Signed-off-by: Max Buchholz <max.buchholz@gmx.de>
---
.../bindings/input/nvidia,tegra20-kbc.txt | 55 ---------
.../bindings/input/nvidia,tegra20-kbc.yaml | 109 ++++++++++++++++++
2 files changed, 109 insertions(+), 55 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.txt
create mode 100644 Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.yaml
diff --git a/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.txt b/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.txt
deleted file mode 100644
index 1faa7292e21f..000000000000
--- a/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.txt
+++ /dev/null
@@ -1,55 +0,0 @@
-* Tegra keyboard controller
-The key controller has maximum 24 pins to make matrix keypad. Any pin
-can be configured as row or column. The maximum column pin can be 8
-and maximum row pins can be 16 for Tegra20/Tegra30.
-
-Required properties:
-- compatible: "nvidia,tegra20-kbc"
-- reg: Register base address of KBC.
-- interrupts: Interrupt number for the KBC.
-- nvidia,kbc-row-pins: The KBC pins which are configured as row. This is an
- array of pin numbers which is used as rows.
-- nvidia,kbc-col-pins: The KBC pins which are configured as column. This is an
- array of pin numbers which is used as column.
-- linux,keymap: The keymap for keys as described in the binding document
- devicetree/bindings/input/matrix-keymap.txt.
-- clocks: Must contain one entry, for the module clock.
- See ../clocks/clock-bindings.txt for details.
-- resets: Must contain an entry for each entry in reset-names.
- See ../reset/reset.txt for details.
-- reset-names: Must include the following entries:
- - kbc
-
-Optional properties, in addition to those specified by the shared
-matrix-keyboard bindings:
-
-- linux,fn-keymap: a second keymap, same specification as the
- matrix-keyboard-controller spec but to be used when the KEY_FN modifier
- key is pressed.
-- nvidia,debounce-delay-ms: delay in milliseconds per row scan for debouncing
-- nvidia,repeat-delay-ms: delay in milliseconds before repeat starts
-- nvidia,ghost-filter: enable ghost filtering for this device
-- wakeup-source: configure keyboard as a wakeup source for suspend/resume
- (Legacy property supported: "nvidia,wakeup-source")
-
-Example:
-
-keyboard: keyboard {
- compatible = "nvidia,tegra20-kbc";
- reg = <0x7000e200 0x100>;
- interrupts = <0 85 0x04>;
- clocks = <&tegra_car 36>;
- resets = <&tegra_car 36>;
- reset-names = "kbc";
- nvidia,ghost-filter;
- nvidia,debounce-delay-ms = <640>;
- nvidia,kbc-row-pins = <0 1 2>; /* pin 0, 1, 2 as rows */
- nvidia,kbc-col-pins = <11 12 13>; /* pin 11, 12, 13 as columns */
- linux,keymap = <0x00000074
- 0x00010067
- 0x00020066
- 0x01010068
- 0x02000069
- 0x02010070
- 0x02020071>;
-};
diff --git a/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.yaml b/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.yaml
new file mode 100644
index 000000000000..8ecd42e02f09
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.yaml
@@ -0,0 +1,109 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/input/nvidia,tegra20-kbc.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Nvidia Tegra keyboard controller
+
+maintainers:
+ - Jon Hunter <jonathanh@nvidia.com>
+ - Sameer Pujar <spujar@nvidia.com>
+
+description: The key controller has maximum 24 pins to make matrix keypad. Any pin
+ can be configured as row or column.
+
+allOf:
+ - $ref: "/schemas/input/matrix-keymap.yaml#"
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - const: nvidia,tegra30-kbc
+ - const: nvidia,tegra20-kbc
+ - items:
+ - const: nvidia,tegra20-kbc
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ nvidia,kbc-row-pins:
+ maxItems: 16
+ description: KBC pins which are configured as row
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+
+ nvidia,kbc-col-pins:
+ maxItems: 8
+ description: KBC pins which are configured as column
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+
+ clocks:
+ maxItems: 1
+
+ resets:
+ maxItems: 1
+
+ reset-names:
+ const: kbc
+
+ linux,fn-keymap:
+ description: a secondary keymap to be used when the KEY_FN modifier key is pressed
+
+ nvidia,debounce-delay-ms:
+ description: delay in milliseconds per row scan for debouncing
+
+ nvidia,repeat-delay-ms:
+ description: delay in milliseconds before repeat starts
+
+ nvidia,ghost-filter:
+ description: enable ghost filtering for this device
+ type: boolean
+
+ wakeup-source:
+ description: configure keyboard as a wakeup source for suspend/resume
+
+ nvidia,wakeup-source:
+ description: configure keyboard as a wakeup source for suspend/resume
+ deprecated: true
+ type: boolean
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - nvidia,kbc-row-pins
+ - nvidia,kbc-col-pins
+ - linux,keymap
+ - clocks
+ - resets
+ - reset-names
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ kbc@7000e200 {
+ compatible = "nvidia,tegra20-kbc";
+ reg = <0x7000e200 0x100>;
+ interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&tegra_car 36>;
+ resets = <&tegra_car 36>;
+ reset-names = "kbc";
+ nvidia,ghost-filter;
+ nvidia,debounce-delay-ms = <640>;
+ nvidia,kbc-row-pins = <0 1 2>; /* pin 0, 1, 2 as rows */
+ nvidia,kbc-col-pins = <11 12 13>; /* pin 11, 12, 13 as columns */
+ linux,keymap = <0x00000074
+ 0x00010067
+ 0x00020066
+ 0x01010068
+ 0x02000069
+ 0x02010070
+ 0x02020071>;
+ };
--
2.37.0On Thu, 14 Jul 2022 17:37:31 +0200, Max Buchholz wrote: > From: Max Buchholz <Max.Buchholz@gmx.de> > > This converts the Nvidia Tegra keyboard controller bindings to YAML > and fix them up a bit. > > Reviewed-by: David Heidelberg <david@ixit.cz> > Signed-off-by: Max Buchholz <max.buchholz@gmx.de> > --- > .../bindings/input/nvidia,tegra20-kbc.txt | 55 --------- > .../bindings/input/nvidia,tegra20-kbc.yaml | 109 ++++++++++++++++++ > 2 files changed, 109 insertions(+), 55 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.txt > create mode 100644 Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.example.dtb: kbc@7000e200: nvidia,kbc-row-pins: 'oneOf' conditional failed, one must be fixed: [0, 1, 2] is too long [0, 1, 2] is too short From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.example.dtb: kbc@7000e200: nvidia,kbc-col-pins: 'oneOf' conditional failed, one must be fixed: [11, 12, 13] is too long [11, 12, 13] is too short From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.example.dtb: kbc@7000e200: 'linux,keymap' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.yaml doc reference errors (make refcheckdocs): Documentation/devicetree/bindings/power/wakeup-source.txt: Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.txt See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
© 2016 - 2026 Red Hat, Inc.