[PATCH -next] writeback: Cleanup inode_to_wb_is_valid()

Xiu Jianfeng posted 1 patch 3 years, 9 months ago
include/linux/backing-dev.h | 17 -----------------
1 file changed, 17 deletions(-)
[PATCH -next] writeback: Cleanup inode_to_wb_is_valid()
Posted by Xiu Jianfeng 3 years, 9 months ago
inode_to_wb_is_valid() is no longer used since commit fe55d563d417
("remove inode_congested()"), remove it.

Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
 include/linux/backing-dev.h | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index d452071db572..f9f14e385582 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -235,18 +235,6 @@ wb_get_create_current(struct backing_dev_info *bdi, gfp_t gfp)
 	return wb;
 }
 
-/**
- * inode_to_wb_is_valid - test whether an inode has a wb associated
- * @inode: inode of interest
- *
- * Returns %true if @inode has a wb associated.  May be called without any
- * locking.
- */
-static inline bool inode_to_wb_is_valid(struct inode *inode)
-{
-	return inode->i_wb;
-}
-
 /**
  * inode_to_wb - determine the wb of an inode
  * @inode: inode of interest
@@ -345,11 +333,6 @@ wb_get_create_current(struct backing_dev_info *bdi, gfp_t gfp)
 	return &bdi->wb;
 }
 
-static inline bool inode_to_wb_is_valid(struct inode *inode)
-{
-	return true;
-}
-
 static inline struct bdi_writeback *inode_to_wb(struct inode *inode)
 {
 	return &inode_to_bdi(inode)->wb;
-- 
2.17.1
Re: [PATCH -next] writeback: Cleanup inode_to_wb_is_valid()
Posted by Jan Kara 3 years, 9 months ago
On Thu 14-07-22 16:41:47, Xiu Jianfeng wrote:
> inode_to_wb_is_valid() is no longer used since commit fe55d563d417
> ("remove inode_congested()"), remove it.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>

Looks good! Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  include/linux/backing-dev.h | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
> index d452071db572..f9f14e385582 100644
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -235,18 +235,6 @@ wb_get_create_current(struct backing_dev_info *bdi, gfp_t gfp)
>  	return wb;
>  }
>  
> -/**
> - * inode_to_wb_is_valid - test whether an inode has a wb associated
> - * @inode: inode of interest
> - *
> - * Returns %true if @inode has a wb associated.  May be called without any
> - * locking.
> - */
> -static inline bool inode_to_wb_is_valid(struct inode *inode)
> -{
> -	return inode->i_wb;
> -}
> -
>  /**
>   * inode_to_wb - determine the wb of an inode
>   * @inode: inode of interest
> @@ -345,11 +333,6 @@ wb_get_create_current(struct backing_dev_info *bdi, gfp_t gfp)
>  	return &bdi->wb;
>  }
>  
> -static inline bool inode_to_wb_is_valid(struct inode *inode)
> -{
> -	return true;
> -}
> -
>  static inline struct bdi_writeback *inode_to_wb(struct inode *inode)
>  {
>  	return &inode_to_bdi(inode)->wb;
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR
Re: [PATCH -next] writeback: Cleanup inode_to_wb_is_valid()
Posted by Johannes Thumshirn 3 years, 9 months ago
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>