[PATCH -next RESEND] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()

Yang Li posted 1 patch 3 years, 9 months ago
drivers/soc/qcom/icc-bwmon.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
[PATCH -next RESEND] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()
Posted by Yang Li 3 years, 9 months ago
Eliminate the follow coccicheck warning:
./drivers/soc/qcom/icc-bwmon.c:349:2-9: line 349 is redundant because platform_get_irq() already prints an error

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/soc/qcom/icc-bwmon.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/soc/qcom/icc-bwmon.c b/drivers/soc/qcom/icc-bwmon.c
index bea3ea1de7a4..7f8aca533cd3 100644
--- a/drivers/soc/qcom/icc-bwmon.c
+++ b/drivers/soc/qcom/icc-bwmon.c
@@ -345,10 +345,8 @@ static int bwmon_probe(struct platform_device *pdev)
 	}
 
 	bwmon->irq = platform_get_irq(pdev, 0);
-	if (bwmon->irq < 0) {
-		dev_err(dev, "failed to acquire bwmon IRQ\n");
+	if (bwmon->irq < 0)
 		return bwmon->irq;
-	}
 
 	ret = devm_pm_opp_of_add_table(dev);
 	if (ret)
-- 
2.20.1.7.g153144c
Re: (subset) [PATCH -next RESEND] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()
Posted by Bjorn Andersson 3 years, 9 months ago
On Thu, 14 Jul 2022 15:55:32 +0800, Yang Li wrote:
> Eliminate the follow coccicheck warning:
> ./drivers/soc/qcom/icc-bwmon.c:349:2-9: line 349 is redundant because platform_get_irq() already prints an error
> 
> 

Applied, thanks!

[1/1] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()
      commit: 947bb0d16576bdac27f3355f268f51acfe29bfa7

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>
Re: [PATCH -next RESEND] soc: qcom: icc-bwmon: Remove unnecessary print function dev_err()
Posted by Krzysztof Kozlowski 3 years, 9 months ago
On 14/07/2022 09:55, Yang Li wrote:
> Eliminate the follow coccicheck warning:
> ./drivers/soc/qcom/icc-bwmon.c:349:2-9: line 349 is redundant because platform_get_irq() already prints an error
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof