kernel: watchdog: fix missing space coding style issue

[PATCH] kernel: watchdog: fix missing space coding style issue

Posted by Gavin Keusch 3 years, 9 months ago

Fixed missing space causing coding style error

Signed-off-by: Gavin Keusch <gavinkeusch@gmail.com>
---
 kernel/watchdog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index ecb0e8346e65..b6b150c4b179 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -306,7 +306,7 @@ static int is_softlockup(unsigned long touch_ts,
 			 unsigned long period_ts,
 			 unsigned long now)
 {
-	if ((watchdog_enabled & SOFT_WATCHDOG_ENABLED) && watchdog_thresh){
+	if ((watchdog_enabled & SOFT_WATCHDOG_ENABLED) && watchdog_thresh) {
 		/* Warn about unreasonable delays. */
 		if (time_after(now, period_ts + get_softlockup_thresh()))
 			return now - touch_ts;
-- 
2.34.1

Re: [PATCH] kernel: watchdog: fix missing space coding style issue

Posted by Petr Mladek 3 years, 9 months ago

Adding Andrew into Cc who usually takes patches for kernel/watchdog.c.

Best Regards,
Petr

On Wed 2022-07-13 23:04:57, Gavin Keusch wrote:
> Fixed missing space causing coding style error
> 
> Signed-off-by: Gavin Keusch <gavinkeusch@gmail.com>
> ---
>  kernel/watchdog.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index ecb0e8346e65..b6b150c4b179 100644
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -306,7 +306,7 @@ static int is_softlockup(unsigned long touch_ts,
>  			 unsigned long period_ts,
>  			 unsigned long now)
>  {
> -	if ((watchdog_enabled & SOFT_WATCHDOG_ENABLED) && watchdog_thresh){
> +	if ((watchdog_enabled & SOFT_WATCHDOG_ENABLED) && watchdog_thresh) {
>  		/* Warn about unreasonable delays. */
>  		if (time_after(now, period_ts + get_softlockup_thresh()))
>  			return now - touch_ts;
> -- 
> 2.34.1

Re: [PATCH] kernel: watchdog: fix missing space coding style issue

Posted by Andrew Morton 3 years, 9 months ago

On Thu, 14 Jul 2022 10:31:49 +0200 Petr Mladek <pmladek@suse.com> wrote:

> Adding Andrew into Cc who usually takes patches for kernel/watchdog.c.
> 
> Best Regards,
> Petr
> 
> On Wed 2022-07-13 23:04:57, Gavin Keusch wrote:
> > Fixed missing space causing coding style error
> > 
> > Signed-off-by: Gavin Keusch <gavinkeusch@gmail.com>
> > ---
> >  kernel/watchdog.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> > index ecb0e8346e65..b6b150c4b179 100644
> > --- a/kernel/watchdog.c
> > +++ b/kernel/watchdog.c
> > @@ -306,7 +306,7 @@ static int is_softlockup(unsigned long touch_ts,
> >  			 unsigned long period_ts,
> >  			 unsigned long now)
> >  {
> > -	if ((watchdog_enabled & SOFT_WATCHDOG_ENABLED) && watchdog_thresh){
> > +	if ((watchdog_enabled & SOFT_WATCHDOG_ENABLED) && watchdog_thresh) {
> >  		/* Warn about unreasonable delays. */
> >  		if (time_after(now, period_ts + get_softlockup_thresh()))
> >  			return now - touch_ts;

Patch is too minor to justify merging, sorry.  If it fixed 15
coding-style errors then maybe.  But this way just leads to too much
noise.