[PATCH] PCI/ASPM: Unexport pcie_aspm_support_enabled()

Bjorn Helgaas posted 1 patch 3 years, 9 months ago
drivers/pci/pcie/aspm.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] PCI/ASPM: Unexport pcie_aspm_support_enabled()
Posted by Bjorn Helgaas 3 years, 9 months ago
From: Bjorn Helgaas <bhelgaas@google.com>

pcie_aspm_support_enabled() is used only by the acpi/pci_root.c driver,
which cannot be built as a module, so it does not need to be exported.
Unexport it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/pcie/aspm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
index 7f76a5875feb..a8aec190986c 100644
--- a/drivers/pci/pcie/aspm.c
+++ b/drivers/pci/pcie/aspm.c
@@ -1347,4 +1347,3 @@ bool pcie_aspm_support_enabled(void)
 {
 	return aspm_support_enabled;
 }
-EXPORT_SYMBOL(pcie_aspm_support_enabled);
-- 
2.25.1
Re: [PATCH] PCI/ASPM: Unexport pcie_aspm_support_enabled()
Posted by Rafael J. Wysocki 3 years, 9 months ago
On Tue, Jul 12, 2022 at 1:14 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> pcie_aspm_support_enabled() is used only by the acpi/pci_root.c driver,
> which cannot be built as a module, so it does not need to be exported.
> Unexport it.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

> ---
>  drivers/pci/pcie/aspm.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> index 7f76a5875feb..a8aec190986c 100644
> --- a/drivers/pci/pcie/aspm.c
> +++ b/drivers/pci/pcie/aspm.c
> @@ -1347,4 +1347,3 @@ bool pcie_aspm_support_enabled(void)
>  {
>         return aspm_support_enabled;
>  }
> -EXPORT_SYMBOL(pcie_aspm_support_enabled);
> --
> 2.25.1
>
Re: [PATCH] PCI/ASPM: Unexport pcie_aspm_support_enabled()
Posted by Bjorn Helgaas 3 years, 9 months ago
On Tue, Jul 12, 2022 at 08:10:03PM +0200, Rafael J. Wysocki wrote:
> On Tue, Jul 12, 2022 at 1:14 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
> >
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > pcie_aspm_support_enabled() is used only by the acpi/pci_root.c driver,
> > which cannot be built as a module, so it does not need to be exported.
> > Unexport it.
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> 
> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Thanks, applied with your Reviewed-by to pci/aspm for v5.20.

> > ---
> >  drivers/pci/pcie/aspm.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> > index 7f76a5875feb..a8aec190986c 100644
> > --- a/drivers/pci/pcie/aspm.c
> > +++ b/drivers/pci/pcie/aspm.c
> > @@ -1347,4 +1347,3 @@ bool pcie_aspm_support_enabled(void)
> >  {
> >         return aspm_support_enabled;
> >  }
> > -EXPORT_SYMBOL(pcie_aspm_support_enabled);
> > --
> > 2.25.1
> >