[PATCH v2 0/2] dt-bindings: sound: Convert to json-schema

Ryan.Wanner@microchip.com posted 2 patches 3 years, 9 months ago
.../bindings/sound/atmel,sama5d2-classd.yaml  | 104 ++++++++++++++++++
.../bindings/sound/atmel,sama5d2-pdmic.yaml   |  98 +++++++++++++++++
.../bindings/sound/atmel-classd.txt           |  55 ---------
.../devicetree/bindings/sound/atmel-pdmic.txt |  55 ---------
4 files changed, 202 insertions(+), 110 deletions(-)
create mode 100644 Documentation/devicetree/bindings/sound/atmel,sama5d2-classd.yaml
create mode 100644 Documentation/devicetree/bindings/sound/atmel,sama5d2-pdmic.yaml
delete mode 100644 Documentation/devicetree/bindings/sound/atmel-classd.txt
delete mode 100644 Documentation/devicetree/bindings/sound/atmel-pdmic.txt
[PATCH v2 0/2] dt-bindings: sound: Convert to json-schema
Posted by Ryan.Wanner@microchip.com 3 years, 9 months ago
From: Ryan Wanner <Ryan.Wanner@microchip.com>

This patch series converts atmel-classd and atmel-pdmic device tree
bindings to json-schema.

v1 -> v2:
- Fix commit formatting.
- Fix titles in yaml file
- Removed trivial descriptions
- Correct formatting errors 

Ryan Wanner (2):
  dt-bindings: sound: atmel,classd: Convert to json-schema
  dt-binding: sound: atmel,pdmic: Convert to json-schema

 .../bindings/sound/atmel,sama5d2-classd.yaml  | 104 ++++++++++++++++++
 .../bindings/sound/atmel,sama5d2-pdmic.yaml   |  98 +++++++++++++++++
 .../bindings/sound/atmel-classd.txt           |  55 ---------
 .../devicetree/bindings/sound/atmel-pdmic.txt |  55 ---------
 4 files changed, 202 insertions(+), 110 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/sound/atmel,sama5d2-classd.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/atmel,sama5d2-pdmic.yaml
 delete mode 100644 Documentation/devicetree/bindings/sound/atmel-classd.txt
 delete mode 100644 Documentation/devicetree/bindings/sound/atmel-pdmic.txt

-- 
2.34.1
Re: [PATCH v2 0/2] dt-bindings: sound: Convert to json-schema
Posted by Krzysztof Kozlowski 3 years, 9 months ago
On 11/07/2022 20:30, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
> 
> This patch series converts atmel-classd and atmel-pdmic device tree
> bindings to json-schema.
> 
> v1 -> v2:
> - Fix commit formatting.
> - Fix titles in yaml file
> - Removed trivial descriptions
> - Correct formatting errors 
> 
> Ryan Wanner (2):
>   dt-bindings: sound: atmel,classd: Convert to json-schema
>   dt-binding: sound: atmel,pdmic: Convert to json-schema

Use consistent and proper prefix. I think you got such comment before,
right?


Best regards,
Krzysztof
Re: [PATCH v2 0/2] dt-bindings: sound: Convert to json-schema
Posted by Conor.Dooley@microchip.com 3 years, 9 months ago
Hey Ryan,
Thanks for your patches, got a couple comments.

On 11/07/2022 19:30, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
> 
> This patch series converts atmel-classd and atmel-pdmic device tree
> bindings to json-schema.
> 
> v1 -> v2:
> - Fix commit formatting.

For sound bindings, I afaik the standard way to do it is:
"ASoC: dt-bindings: foo"

If you ever want to get an idea of what subjects for a
subsystem should look like you can always run:

git log --oneline path/to/subsystem

So for these patches:

git log --oneline Documentation/devicetree/bindings/sound/
> - Fix titles in yaml file
> - Removed trivial descriptions
> - Correct formatting errors 
> 
> Ryan Wanner (2):
>   dt-bindings: sound: atmel,classd: Convert to json-schema
>   dt-binding: sound: atmel,pdmic: Convert to json-schema
              ^ forgot the s here

Thanks,
Conor.