usb: misc: onboard_hub: Fix 'missing prototype' warning

[PATCH] usb: misc: onboard_hub: Fix 'missing prototype' warning

Posted by Matthias Kaehlcke 3 years, 9 months ago

When building with 'W=1' the compiler complains about missing
prototypes for onboard_hub_create/destroy_pdevs(). Include the
header with the prototypes to fix this.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---

 drivers/usb/misc/onboard_usb_hub_pdevs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/misc/onboard_usb_hub_pdevs.c b/drivers/usb/misc/onboard_usb_hub_pdevs.c
index a0a5f719129f..ed22a18f4ab7 100644
--- a/drivers/usb/misc/onboard_usb_hub_pdevs.c
+++ b/drivers/usb/misc/onboard_usb_hub_pdevs.c
@@ -15,6 +15,7 @@
 #include <linux/usb.h>
 #include <linux/usb/hcd.h>
 #include <linux/usb/of.h>
+#include <linux/usb/onboard_hub.h>
 
 #include "onboard_usb_hub.h"
 
-- 
2.37.0.rc0.161.g10f37bed90-goog

Re: [PATCH] usb: misc: onboard_hub: Fix 'missing prototype' warning

Posted by Doug Anderson 3 years, 9 months ago

Hi,

On Mon, Jul 11, 2022 at 9:25 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> When building with 'W=1' the compiler complains about missing
> prototypes for onboard_hub_create/destroy_pdevs(). Include the
> header with the prototypes to fix this.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>
>  drivers/usb/misc/onboard_usb_hub_pdevs.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Douglas Anderson <dianders@chromium.org>