1. Patchew
  2. linux
  3. View series

[PATCH] arm64: defconfig: Enable Qualcomm SC8280XP providers

Bjorn Andersson posted 1 patch 3 years, 9 months ago 
arch/arm64/configs/defconfig | 3 +++
1 file changed, 3 insertions(+)
[PATCH] arm64: defconfig: Enable Qualcomm SC8280XP providers
Posted by Bjorn Andersson 3 years, 9 months ago 
The Qualcomm SC8280XP need the global clock controller, interconnect
provider and TLMM pinctrl in order to boot. Enable these as builtin, as
they are needed in order to provide e.g. UART.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 arch/arm64/configs/defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index d2615b37d857..8e44f6a2172c 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -541,6 +541,7 @@ CONFIG_PINCTRL_QDF2XXX=y
 CONFIG_PINCTRL_QCOM_SPMI_PMIC=y
 CONFIG_PINCTRL_SC7180=y
 CONFIG_PINCTRL_SC7280=y
+CONFIG_PINCTRL_SC8280XP=y
 CONFIG_PINCTRL_SDM845=y
 CONFIG_PINCTRL_SM8150=y
 CONFIG_PINCTRL_SM8250=y
@@ -1056,6 +1057,7 @@ CONFIG_MSM_GCC_8998=y
 CONFIG_QCS_GCC_404=y
 CONFIG_SC_GCC_7180=y
 CONFIG_SC_GCC_7280=y
+CONFIG_SC_GCC_8280XP=y
 CONFIG_SDM_CAMCC_845=m
 CONFIG_SDM_GPUCC_845=y
 CONFIG_SDM_VIDEOCC_845=y
@@ -1266,6 +1268,7 @@ CONFIG_INTERCONNECT_QCOM_OSM_L3=m
 CONFIG_INTERCONNECT_QCOM_QCS404=m
 CONFIG_INTERCONNECT_QCOM_SC7180=m
 CONFIG_INTERCONNECT_QCOM_SC7280=y
+CONFIG_INTERCONNECT_QCOM_SC8280XP=y
 CONFIG_INTERCONNECT_QCOM_SDM845=y
 CONFIG_INTERCONNECT_QCOM_SM8150=m
 CONFIG_INTERCONNECT_QCOM_SM8250=m
-- 
2.35.1
Re: [PATCH] arm64: defconfig: Enable Qualcomm SC8280XP providers
Posted by Bjorn Andersson 3 years, 9 months ago 
On Thu, 7 Jul 2022 09:10:13 -0700, Bjorn Andersson wrote:
> The Qualcomm SC8280XP need the global clock controller, interconnect
> provider and TLMM pinctrl in order to boot. Enable these as builtin, as
> they are needed in order to provide e.g. UART.
> 
> 

Applied, thanks!

[1/1] arm64: defconfig: Enable Qualcomm SC8280XP providers
      commit: 4cf02f2e0d4dff38dcfe43a168801306aed714dd

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>
Re: [PATCH] arm64: defconfig: Enable Qualcomm SC8280XP providers
Posted by Dmitry Baryshkov 3 years, 9 months ago 
On Thu, 7 Jul 2022 at 19:07, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
>
> The Qualcomm SC8280XP need the global clock controller, interconnect
> provider and TLMM pinctrl in order to boot. Enable these as builtin, as
> they are needed in order to provide e.g. UART.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  arch/arm64/configs/defconfig | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index d2615b37d857..8e44f6a2172c 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -541,6 +541,7 @@ CONFIG_PINCTRL_QDF2XXX=y
>  CONFIG_PINCTRL_QCOM_SPMI_PMIC=y
>  CONFIG_PINCTRL_SC7180=y
>  CONFIG_PINCTRL_SC7280=y
> +CONFIG_PINCTRL_SC8280XP=y
>  CONFIG_PINCTRL_SDM845=y
>  CONFIG_PINCTRL_SM8150=y
>  CONFIG_PINCTRL_SM8250=y
> @@ -1056,6 +1057,7 @@ CONFIG_MSM_GCC_8998=y
>  CONFIG_QCS_GCC_404=y
>  CONFIG_SC_GCC_7180=y
>  CONFIG_SC_GCC_7280=y
> +CONFIG_SC_GCC_8280XP=y
>  CONFIG_SDM_CAMCC_845=m
>  CONFIG_SDM_GPUCC_845=y
>  CONFIG_SDM_VIDEOCC_845=y
> @@ -1266,6 +1268,7 @@ CONFIG_INTERCONNECT_QCOM_OSM_L3=m
>  CONFIG_INTERCONNECT_QCOM_QCS404=m
>  CONFIG_INTERCONNECT_QCOM_SC7180=m
>  CONFIG_INTERCONNECT_QCOM_SC7280=y
> +CONFIG_INTERCONNECT_QCOM_SC8280XP=y

= m? I see other SoCs build interconnect drivers as modules (well,
except sdm845).

>  CONFIG_INTERCONNECT_QCOM_SDM845=y
>  CONFIG_INTERCONNECT_QCOM_SM8150=m
>  CONFIG_INTERCONNECT_QCOM_SM8250=m
> --
> 2.35.1
>


-- 
With best wishes
Dmitry
Re: [PATCH] arm64: defconfig: Enable Qualcomm SC8280XP providers
Posted by Bjorn Andersson 3 years, 9 months ago 
On Thu 07 Jul 10:41 PDT 2022, Dmitry Baryshkov wrote:

> On Thu, 7 Jul 2022 at 19:07, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> >
> > The Qualcomm SC8280XP need the global clock controller, interconnect
> > provider and TLMM pinctrl in order to boot. Enable these as builtin, as
> > they are needed in order to provide e.g. UART.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> >  arch/arm64/configs/defconfig | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index d2615b37d857..8e44f6a2172c 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -541,6 +541,7 @@ CONFIG_PINCTRL_QDF2XXX=y
> >  CONFIG_PINCTRL_QCOM_SPMI_PMIC=y
> >  CONFIG_PINCTRL_SC7180=y
> >  CONFIG_PINCTRL_SC7280=y
> > +CONFIG_PINCTRL_SC8280XP=y
> >  CONFIG_PINCTRL_SDM845=y
> >  CONFIG_PINCTRL_SM8150=y
> >  CONFIG_PINCTRL_SM8250=y
> > @@ -1056,6 +1057,7 @@ CONFIG_MSM_GCC_8998=y
> >  CONFIG_QCS_GCC_404=y
> >  CONFIG_SC_GCC_7180=y
> >  CONFIG_SC_GCC_7280=y
> > +CONFIG_SC_GCC_8280XP=y
> >  CONFIG_SDM_CAMCC_845=m
> >  CONFIG_SDM_GPUCC_845=y
> >  CONFIG_SDM_VIDEOCC_845=y
> > @@ -1266,6 +1268,7 @@ CONFIG_INTERCONNECT_QCOM_OSM_L3=m
> >  CONFIG_INTERCONNECT_QCOM_QCS404=m
> >  CONFIG_INTERCONNECT_QCOM_SC7180=m
> >  CONFIG_INTERCONNECT_QCOM_SC7280=y
> > +CONFIG_INTERCONNECT_QCOM_SC8280XP=y
> 
> = m? I see other SoCs build interconnect drivers as modules (well,
> except sdm845).
> 

I have interconnects specified for the UART and keeping the interconnect
provider as module means that the serial  until after late_initcall,
which in my testing implies that systemd doesn't find a proper console.

Perhaps this is something I'm doing incorrectly?

Regards,
Bjorn

> >  CONFIG_INTERCONNECT_QCOM_SDM845=y
> >  CONFIG_INTERCONNECT_QCOM_SM8150=m
> >  CONFIG_INTERCONNECT_QCOM_SM8250=m
> > --
> > 2.35.1
> >
> 
> 
> -- 
> With best wishes
> Dmitry
Re: [PATCH] arm64: defconfig: Enable Qualcomm SC8280XP providers
Posted by Manivannan Sadhasivam 3 years, 9 months ago 
On Fri, Jul 08, 2022 at 02:04:13PM -0700, Bjorn Andersson wrote:
> On Thu 07 Jul 10:41 PDT 2022, Dmitry Baryshkov wrote:
> 
> > On Thu, 7 Jul 2022 at 19:07, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> > >
> > > The Qualcomm SC8280XP need the global clock controller, interconnect
> > > provider and TLMM pinctrl in order to boot. Enable these as builtin, as
> > > they are needed in order to provide e.g. UART.
> > >
> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > > ---
> > >  arch/arm64/configs/defconfig | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > > index d2615b37d857..8e44f6a2172c 100644
> > > --- a/arch/arm64/configs/defconfig
> > > +++ b/arch/arm64/configs/defconfig
> > > @@ -541,6 +541,7 @@ CONFIG_PINCTRL_QDF2XXX=y
> > >  CONFIG_PINCTRL_QCOM_SPMI_PMIC=y
> > >  CONFIG_PINCTRL_SC7180=y
> > >  CONFIG_PINCTRL_SC7280=y
> > > +CONFIG_PINCTRL_SC8280XP=y
> > >  CONFIG_PINCTRL_SDM845=y
> > >  CONFIG_PINCTRL_SM8150=y
> > >  CONFIG_PINCTRL_SM8250=y
> > > @@ -1056,6 +1057,7 @@ CONFIG_MSM_GCC_8998=y
> > >  CONFIG_QCS_GCC_404=y
> > >  CONFIG_SC_GCC_7180=y
> > >  CONFIG_SC_GCC_7280=y
> > > +CONFIG_SC_GCC_8280XP=y
> > >  CONFIG_SDM_CAMCC_845=m
> > >  CONFIG_SDM_GPUCC_845=y
> > >  CONFIG_SDM_VIDEOCC_845=y
> > > @@ -1266,6 +1268,7 @@ CONFIG_INTERCONNECT_QCOM_OSM_L3=m
> > >  CONFIG_INTERCONNECT_QCOM_QCS404=m
> > >  CONFIG_INTERCONNECT_QCOM_SC7180=m
> > >  CONFIG_INTERCONNECT_QCOM_SC7280=y
> > > +CONFIG_INTERCONNECT_QCOM_SC8280XP=y
> > 
> > = m? I see other SoCs build interconnect drivers as modules (well,
> > except sdm845).
> > 
> 
> I have interconnects specified for the UART and keeping the interconnect
> provider as module means that the serial  until after late_initcall,
> which in my testing implies that systemd doesn't find a proper console.
> 
> Perhaps this is something I'm doing incorrectly?
> 

Only couple of SoCs have defined interconnect providers for UART, so I think
it is fine to make it built-in. It will get extended to most of the SoCs in
future when they get optimized.

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> Regards,
> Bjorn
> 
> > >  CONFIG_INTERCONNECT_QCOM_SDM845=y
> > >  CONFIG_INTERCONNECT_QCOM_SM8150=m
> > >  CONFIG_INTERCONNECT_QCOM_SM8250=m
> > > --
> > > 2.35.1
> > >
> > 
> > 
> > -- 
> > With best wishes
> > Dmitry

-- 
மணிவண்ணன் சதாசிவம்

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.