1. Patchew
  2. linux
  3. View series

[PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188

Johnson Wang posted 1 patch 3 years, 7 months ago
There is a newer version of this series
Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
1 file changed, 3 insertions(+)
[PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
Posted by Johnson Wang 3 years, 7 months ago 
This commit adds dt-binding documentation of mmc for MediaTek MT8188 SoC
platform.

Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
---
 Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
index 2a2e9fa8c188..3fbf33ad4f7c 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
@@ -32,6 +32,9 @@ properties:
       - items:
           - const: mediatek,mt8186-mmc
           - const: mediatek,mt8183-mmc
+      - items:
+          - const: mediatek,mt8188-mmc
+          - const: mediatek,mt8183-mmc
       - items:
           - const: mediatek,mt8192-mmc
           - const: mediatek,mt8183-mmc
-- 
2.18.0
Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
Posted by AngeloGioacchino Del Regno 3 years, 7 months ago 
Il 07/07/22 07:47, Johnson Wang ha scritto:
> This commit adds dt-binding documentation of mmc for MediaTek MT8188 SoC
> platform.
> 
> Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
> ---
>   Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 2a2e9fa8c188..3fbf33ad4f7c 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -32,6 +32,9 @@ properties:
>         - items:
>             - const: mediatek,mt8186-mmc
>             - const: mediatek,mt8183-mmc
> +      - items:
> +          - const: mediatek,mt8188-mmc
> +          - const: mediatek,mt8183-mmc
>         - items:
>             - const: mediatek,mt8192-mmc
>             - const: mediatek,mt8183-mmc
> 

Hello Johnson,

if I'm not wrong, this should be...
(check with dt_binding_check!)

properties:
   compatible:
     oneOf:
       - enum:
         - mediatek,mt2701-mmc
         - .... everything else ....
       - items:
         - enum:
             - mediatek,mt8186-mmc
             - ... the others ...
         - const: mediatek.mt8183-mmc

Cheers,
Angelo
Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
Posted by Krzysztof Kozlowski 3 years, 7 months ago 
On 07/07/2022 07:47, Johnson Wang wrote:
> This commit adds dt-binding documentation of mmc for MediaTek MT8188 SoC
> platform.
> 
> Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
> ---
>  Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 2a2e9fa8c188..3fbf33ad4f7c 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -32,6 +32,9 @@ properties:
>        - items:
>            - const: mediatek,mt8186-mmc
>            - const: mediatek,mt8183-mmc
> +      - items:
> +          - const: mediatek,mt8188-mmc

You duplicate quite a lot. Use enum.

Best regards,
Krzysztof
Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
Posted by Johnson Wang 3 years, 7 months ago 
On Thu, 2022-07-07 at 08:46 +0200, Krzysztof Kozlowski wrote:
> On 07/07/2022 07:47, Johnson Wang wrote:
> > This commit adds dt-binding documentation of mmc for MediaTek
> > MT8188 SoC
> > platform.
> > 
> > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
> > ---
> >  Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > index 2a2e9fa8c188..3fbf33ad4f7c 100644
> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > @@ -32,6 +32,9 @@ properties:
> >        - items:
> >            - const: mediatek,mt8186-mmc
> >            - const: mediatek,mt8183-mmc
> > +      - items:
> > +          - const: mediatek,mt8188-mmc
> 
> You duplicate quite a lot. Use enum.
> 
> Best regards,
> Krzysztof

Hi Krzysztof,

Thanks for you suggestion.

I will use 'enum' to place this compatible strings.

Just like this:
- items:
    - enum:
        - mediatek,mt8186-mmc
        - mediatek,mt8188-mmc
        - mediatek,mt8192-mmc
        - mediatek,mt8195-mmc
    - const: mediatek,mt8183-mmc

Moreover, it seems that missing an "items:" between oneOf and enum in
the compatible property.
Is my understanding wrong?

BRs,
Johnson Wang
Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
Posted by Krzysztof Kozlowski 3 years, 7 months ago 
On 07/07/2022 09:30, Johnson Wang wrote:
> On Thu, 2022-07-07 at 08:46 +0200, Krzysztof Kozlowski wrote:
>> On 07/07/2022 07:47, Johnson Wang wrote:
>>> This commit adds dt-binding documentation of mmc for MediaTek
>>> MT8188 SoC
>>> platform.
>>>
>>> Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
>>> ---
>>>  Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> index 2a2e9fa8c188..3fbf33ad4f7c 100644
>>> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> @@ -32,6 +32,9 @@ properties:
>>>        - items:
>>>            - const: mediatek,mt8186-mmc
>>>            - const: mediatek,mt8183-mmc
>>> +      - items:
>>> +          - const: mediatek,mt8188-mmc
>>
>> You duplicate quite a lot. Use enum.
>>
>> Best regards,
>> Krzysztof
> 
> Hi Krzysztof,
> 
> Thanks for you suggestion.
> 
> I will use 'enum' to place this compatible strings.
> 
> Just like this:
> - items:
>     - enum:
>         - mediatek,mt8186-mmc
>         - mediatek,mt8188-mmc
>         - mediatek,mt8192-mmc
>         - mediatek,mt8195-mmc
>     - const: mediatek,mt8183-mmc
> 
> Moreover, it seems that missing an "items:" between oneOf and enum in
> the compatible property.
> Is my understanding wrong?

I did not propose to remove items, so where are they missing? Not sure
what you are asking about...

Best regards,
Krzysztof
Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
Posted by Johnson Wang 3 years, 7 months ago 
On Mon, 2022-07-11 at 13:02 +0200, Krzysztof Kozlowski wrote:
> On 07/07/2022 09:30, Johnson Wang wrote:
> > On Thu, 2022-07-07 at 08:46 +0200, Krzysztof Kozlowski wrote:
> > > On 07/07/2022 07:47, Johnson Wang wrote:
> > > > This commit adds dt-binding documentation of mmc for MediaTek
> > > > MT8188 SoC
> > > > platform.
> > > > 
> > > > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
> > > >  1 file changed, 3 insertions(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > > > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > > > index 2a2e9fa8c188..3fbf33ad4f7c 100644
> > > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > > > @@ -32,6 +32,9 @@ properties:
> > > >        - items:
> > > >            - const: mediatek,mt8186-mmc
> > > >            - const: mediatek,mt8183-mmc
> > > > +      - items:
> > > > +          - const: mediatek,mt8188-mmc
> > > 
> > > You duplicate quite a lot. Use enum.
> > > 
> > > Best regards,
> > > Krzysztof
> > 
> > Hi Krzysztof,
> > 
> > Thanks for you suggestion.
> > 
> > I will use 'enum' to place this compatible strings.
> > 
> > Just like this:
> > - items:
> >     - enum:
> >         - mediatek,mt8186-mmc
> >         - mediatek,mt8188-mmc
> >         - mediatek,mt8192-mmc
> >         - mediatek,mt8195-mmc
> >     - const: mediatek,mt8183-mmc
> > 
> > Moreover, it seems that missing an "items:" between oneOf and enum
> > in
> > the compatible property.
> > Is my understanding wrong?
> 
> I did not propose to remove items, so where are they missing? Not
> sure
> what you are asking about...
> 
> Best regards,
> Krzysztof

Hi Krzysztof,

Sorry for the confusion.
That was my misunderstanding. Please ignore it...

BRs,
Johnson Wang

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.