[PATCH -next] net: dsa: b53: remove unnecessary spi_set_drvdata()

Yang Yingliang posted 1 patch 3 years, 9 months ago
drivers/net/dsa/b53/b53_spi.c | 2 --
1 file changed, 2 deletions(-)
[PATCH -next] net: dsa: b53: remove unnecessary spi_set_drvdata()
Posted by Yang Yingliang 3 years, 9 months ago
Remove unnecessary spi_set_drvdata() in b53_spi_remove(), the
driver_data will be set to NULL in device_unbind_cleanup() after
calling ->remove().

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/net/dsa/b53/b53_spi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/dsa/b53/b53_spi.c b/drivers/net/dsa/b53/b53_spi.c
index 0e54b2a0c211..308f15d3832e 100644
--- a/drivers/net/dsa/b53/b53_spi.c
+++ b/drivers/net/dsa/b53/b53_spi.c
@@ -320,8 +320,6 @@ static void b53_spi_remove(struct spi_device *spi)
 
 	if (dev)
 		b53_switch_remove(dev);
-
-	spi_set_drvdata(spi, NULL);
 }
 
 static void b53_spi_shutdown(struct spi_device *spi)
-- 
2.25.1
Re: [PATCH -next] net: dsa: b53: remove unnecessary spi_set_drvdata()
Posted by patchwork-bot+netdevbpf@kernel.org 3 years, 9 months ago
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 5 Jul 2022 21:17:33 +0800 you wrote:
> Remove unnecessary spi_set_drvdata() in b53_spi_remove(), the
> driver_data will be set to NULL in device_unbind_cleanup() after
> calling ->remove().
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/net/dsa/b53/b53_spi.c | 2 --
>  1 file changed, 2 deletions(-)

Here is the summary with links:
  - [-next] net: dsa: b53: remove unnecessary spi_set_drvdata()
    https://git.kernel.org/netdev/net-next/c/6ca4b3932114

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html