ARM: dts: kswitch-d10: use open drain mode for coma-mode pins

[PATCH] ARM: dts: kswitch-d10: use open drain mode for coma-mode pins

Posted by Michael Walle 3 years, 9 months ago

The driver use the coma-mode pins as open-drain. Flag them in the device
tree accordingly. This avoids the following error:
[   14.114180] gpio-2007 (coma-mode): enforced open drain please flag it properly in DT/ACPI DSDT/board file

Fixes: 46a9556d977e ("ARM: dts: kswitch-d10: enable networking")
Signed-off-by: Michael Walle <michael@walle.cc>
---
 arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
index 949d49944a37..5a6c5f7c371a 100644
--- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
+++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
@@ -87,22 +87,22 @@ &mdio0 {
 
 	phy4: ethernet-phy@5 {
 		reg = <5>;
-		coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
+		coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
 	};
 
 	phy5: ethernet-phy@6 {
 		reg = <6>;
-		coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
+		coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
 	};
 
 	phy6: ethernet-phy@7 {
 		reg = <7>;
-		coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
+		coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
 	};
 
 	phy7: ethernet-phy@8 {
 		reg = <8>;
-		coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
+		coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
 	};
 };
 
-- 
2.30.2

Re: [PATCH] ARM: dts: kswitch-d10: use open drain mode for coma-mode pins

Posted by Claudiu.Beznea@microchip.com 3 years, 9 months ago

On 04.07.2022 18:08, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The driver use the coma-mode pins as open-drain. Flag them in the device
> tree accordingly. This avoids the following error:
> [   14.114180] gpio-2007 (coma-mode): enforced open drain please flag it properly in DT/ACPI DSDT/board file
> 
> Fixes: 46a9556d977e ("ARM: dts: kswitch-d10: enable networking")
> Signed-off-by: Michael Walle <michael@walle.cc>

Applied to at91-fixes, thanks!

> ---
>  arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> index 949d49944a37..5a6c5f7c371a 100644
> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> @@ -87,22 +87,22 @@ &mdio0 {
> 
>         phy4: ethernet-phy@5 {
>                 reg = <5>;
> -               coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
> +               coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
>         };
> 
>         phy5: ethernet-phy@6 {
>                 reg = <6>;
> -               coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
> +               coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
>         };
> 
>         phy6: ethernet-phy@7 {
>                 reg = <7>;
> -               coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
> +               coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
>         };
> 
>         phy7: ethernet-phy@8 {
>                 reg = <8>;
> -               coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
> +               coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
>         };
>  };
> 
> --
> 2.30.2
>