[PATCH -next] crypto: ccree: Add missing clk_disable_unprepare() in cc_pm_resume()

Yuan Can posted 1 patch 3 years, 9 months ago
drivers/crypto/ccree/cc_pm.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH -next] crypto: ccree: Add missing clk_disable_unprepare() in cc_pm_resume()
Posted by Yuan Can 3 years, 9 months ago
Add clk_disable_unprepare() on error path in cc_pm_resume().

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yuan Can <yuancan@huawei.com>
---
 drivers/crypto/ccree/cc_pm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/crypto/ccree/cc_pm.c b/drivers/crypto/ccree/cc_pm.c
index d5421b0c6831..6124fbbbed94 100644
--- a/drivers/crypto/ccree/cc_pm.c
+++ b/drivers/crypto/ccree/cc_pm.c
@@ -41,6 +41,7 @@ static int cc_pm_resume(struct device *dev)
 	/* wait for Cryptocell reset completion */
 	if (!cc_wait_for_reset_completion(drvdata)) {
 		dev_err(dev, "Cryptocell reset not completed");
+		clk_disable_unprepare(drvdata->clk);
 		return -EBUSY;
 	}
 
@@ -48,6 +49,7 @@ static int cc_pm_resume(struct device *dev)
 	rc = init_cc_regs(drvdata);
 	if (rc) {
 		dev_err(dev, "init_cc_regs (%x)\n", rc);
+		clk_disable_unprepare(drvdata->clk);
 		return rc;
 	}
 	/* check if tee fips error occurred during power down */
-- 
2.17.1
Re: [PATCH -next] crypto: ccree: Add missing clk_disable_unprepare() in cc_pm_resume()
Posted by Herbert Xu 3 years, 9 months ago
On Mon, Jul 04, 2022 at 01:01:45PM +0000, Yuan Can wrote:
> Add clk_disable_unprepare() on error path in cc_pm_resume().
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yuan Can <yuancan@huawei.com>
> ---
>  drivers/crypto/ccree/cc_pm.c | 2 ++
>  1 file changed, 2 insertions(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt