virt: acrn: using for_each_set_bit to simplify the code

[PATCH -next] virt: acrn: using for_each_set_bit to simplify the code

Posted by Yang Yingliang 3 years, 9 months ago

It's more cleanly to use for_each_set_bit() instead of opencoding it.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/virt/acrn/ioreq.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/virt/acrn/ioreq.c b/drivers/virt/acrn/ioreq.c
index 5ff1c53740c0..d75ab3f66da4 100644
--- a/drivers/virt/acrn/ioreq.c
+++ b/drivers/virt/acrn/ioreq.c
@@ -246,12 +246,8 @@ void acrn_ioreq_request_clear(struct acrn_vm *vm)
 	spin_lock_bh(&vm->ioreq_clients_lock);
 	client = vm->default_client;
 	if (client) {
-		vcpu = find_first_bit(client->ioreqs_map, ACRN_IO_REQUEST_MAX);
-		while (vcpu < ACRN_IO_REQUEST_MAX) {
+		for_each_set_bit(vcpu, client->ioreqs_map, ACRN_IO_REQUEST_MAX)
 			acrn_ioreq_complete_request(client, vcpu, NULL);
-			vcpu = find_next_bit(client->ioreqs_map,
-					     ACRN_IO_REQUEST_MAX, vcpu + 1);
-		}
 	}
 	spin_unlock_bh(&vm->ioreq_clients_lock);
 
-- 
2.25.1

Re: [PATCH -next] virt: acrn: using for_each_set_bit to simplify the code

Posted by Li Fei1 3 years, 9 months ago

On Mon, Jul 04, 2022 at 08:50:44PM +0800, Yang Yingliang wrote:
> It's more cleanly to use for_each_set_bit() instead of opencoding it.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Signed-off-by: Fei Li <fei1.li@intel.com>

Thanks.

> ---
>  drivers/virt/acrn/ioreq.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/virt/acrn/ioreq.c b/drivers/virt/acrn/ioreq.c
> index 5ff1c53740c0..d75ab3f66da4 100644
> --- a/drivers/virt/acrn/ioreq.c
> +++ b/drivers/virt/acrn/ioreq.c
> @@ -246,12 +246,8 @@ void acrn_ioreq_request_clear(struct acrn_vm *vm)
>  	spin_lock_bh(&vm->ioreq_clients_lock);
>  	client = vm->default_client;
>  	if (client) {
> -		vcpu = find_first_bit(client->ioreqs_map, ACRN_IO_REQUEST_MAX);
> -		while (vcpu < ACRN_IO_REQUEST_MAX) {
> +		for_each_set_bit(vcpu, client->ioreqs_map, ACRN_IO_REQUEST_MAX)
>  			acrn_ioreq_complete_request(client, vcpu, NULL);
> -			vcpu = find_next_bit(client->ioreqs_map,
> -					     ACRN_IO_REQUEST_MAX, vcpu + 1);
> -		}
>  	}
>  	spin_unlock_bh(&vm->ioreq_clients_lock);
>  
> -- 
> 2.25.1
>