keys/keyctl: Fix typo in string

[PATCH] keys/keyctl: Fix typo in string

Posted by Li zeming 3 years, 9 months ago

Remove the repeated ',' from string

Signed-off-by: Li zeming <zeming@nfschina.com>
---
 security/keys/keyctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/keys/keyctl.c b/security/keys/keyctl.c
index 96a92a645216..2be09642dd13 100644
--- a/security/keys/keyctl.c
+++ b/security/keys/keyctl.c
@@ -1175,7 +1175,7 @@ static long keyctl_instantiate_key_common(key_serial_t id,
 	void *payload;
 	long ret;
 
-	kenter("%d,,%zu,%d", id, plen, ringid);
+	kenter("%d,%zu,%d", id, plen, ringid);
 
 	if (!plen)
 		from = NULL;
-- 
2.18.2

Re: [PATCH] keys/keyctl: Fix typo in string

Posted by Jarkko Sakkinen 3 years, 9 months ago

On Mon, Jul 04, 2022 at 10:52:48AM +0800, Li zeming wrote:
> Remove the repeated ',' from string
> 
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>  security/keys/keyctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/keys/keyctl.c b/security/keys/keyctl.c
> index 96a92a645216..2be09642dd13 100644
> --- a/security/keys/keyctl.c
> +++ b/security/keys/keyctl.c
> @@ -1175,7 +1175,7 @@ static long keyctl_instantiate_key_common(key_serial_t id,
>  	void *payload;
>  	long ret;
>  
> -	kenter("%d,,%zu,%d", id, plen, ringid);
> +	kenter("%d,%zu,%d", id, plen, ringid);
>  
>  	if (!plen)
>  		from = NULL;
> -- 
> 2.18.2
> 

Please, add

Fixes: d84f4f992cbd ("CRED: Inaugurate COW credentials")

BR, Jarkko

Re: [PATCH] keys/keyctl: Fix typo in string

Posted by David Howells 3 years, 8 months ago

Jarkko Sakkinen <jarkko@kernel.org> wrote:

> Please, add
> 
> Fixes: d84f4f992cbd ("CRED: Inaugurate COW credentials")

Since it's not a bugfix, I wouldn't put that in.  It doesn't need backporting.

David