[v1] auxdisplay: hd44780: Fix potential memory leak in hd44780_remove()

[PATCH] auxdisplay: hd44780: Fix potential memory leak in hd44780_remove()

Jianglei Nie posted 1 patch 3 years, 9 months ago

Diff against v1 v2 v3
Download mbox

There is a newer version of this series

drivers/auxdisplay/hd44780.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] auxdisplay: hd44780: Fix potential memory leak in hd44780_remove()

Posted by Jianglei Nie 3 years, 9 months ago

hd44780_probe() allocates a memory chunk for hd with kzalloc() and
makes "lcd->drvdata->hd44780" point to it. When we call hd44780_remove(),
we should release all relevant memory and resource, but "lcd->drvdata
->hd44780" is not released, which will lead to a memory leak.

We should release the "lcd->drvdata->hd44780" in hd44780_remove() to fix
the memory leak bug.

Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
---
 drivers/auxdisplay/hd44780.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/auxdisplay/hd44780.c b/drivers/auxdisplay/hd44780.c
index 8b2a0eb3f32a..8940a93d2d4d 100644
--- a/drivers/auxdisplay/hd44780.c
+++ b/drivers/auxdisplay/hd44780.c
@@ -324,6 +324,7 @@ static int hd44780_remove(struct platform_device *pdev)
 	struct charlcd *lcd = platform_get_drvdata(pdev);
 
 	charlcd_unregister(lcd);
+	kfree(lcd->drvdata->hd44780);
 	kfree(lcd->drvdata);
 
 	kfree(lcd);
-- 
2.25.1