staging: r8188eu: make ffaddr2pipehdl() static

[PATCH] staging: r8188eu: make ffaddr2pipehdl() static

Posted by Michael Straube 3 years, 9 months ago

The function ffaddr2pipehdl() is only used in usb_ops_linux.c.
Make it static.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
 drivers/staging/r8188eu/include/usb_ops_linux.h | 2 --
 drivers/staging/r8188eu/os_dep/usb_ops_linux.c  | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/r8188eu/include/usb_ops_linux.h b/drivers/staging/r8188eu/include/usb_ops_linux.h
index 641f059ffaf7..966688eedf66 100644
--- a/drivers/staging/r8188eu/include/usb_ops_linux.h
+++ b/drivers/staging/r8188eu/include/usb_ops_linux.h
@@ -26,6 +26,4 @@
 #define usb_read_interrupt_complete(purb, regs)		\
 	usb_read_interrupt_complete(purb)
 
-unsigned int ffaddr2pipehdl(struct dvobj_priv *pdvobj, u32 addr);
-
 #endif
diff --git a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
index 0269e602b217..220e592b757c 100644
--- a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
+++ b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
@@ -7,7 +7,7 @@
 #include "../include/usb_ops_linux.h"
 #include "../include/rtl8188e_recv.h"
 
-unsigned int ffaddr2pipehdl(struct dvobj_priv *pdvobj, u32 addr)
+static unsigned int ffaddr2pipehdl(struct dvobj_priv *pdvobj, u32 addr)
 {
 	unsigned int pipe = 0, ep_num = 0;
 	struct usb_device *pusbd = pdvobj->pusbdev;
-- 
2.36.1

Re: [PATCH] staging: r8188eu: make ffaddr2pipehdl() static

Posted by Philipp Hortmann 3 years, 9 months ago

On 7/2/22 08:46, Michael Straube wrote:
> The function ffaddr2pipehdl() is only used in usb_ops_linux.c.
> Make it static.
> 
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
> ---
>   drivers/staging/r8188eu/include/usb_ops_linux.h | 2 --
>   drivers/staging/r8188eu/os_dep/usb_ops_linux.c  | 2 +-
>   2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/include/usb_ops_linux.h b/drivers/staging/r8188eu/include/usb_ops_linux.h
> index 641f059ffaf7..966688eedf66 100644
> --- a/drivers/staging/r8188eu/include/usb_ops_linux.h
> +++ b/drivers/staging/r8188eu/include/usb_ops_linux.h
> @@ -26,6 +26,4 @@
>   #define usb_read_interrupt_complete(purb, regs)		\
>   	usb_read_interrupt_complete(purb)
>   
> -unsigned int ffaddr2pipehdl(struct dvobj_priv *pdvobj, u32 addr);
> -
>   #endif
> diff --git a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
> index 0269e602b217..220e592b757c 100644
> --- a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
> +++ b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
> @@ -7,7 +7,7 @@
>   #include "../include/usb_ops_linux.h"
>   #include "../include/rtl8188e_recv.h"
>   
> -unsigned int ffaddr2pipehdl(struct dvobj_priv *pdvobj, u32 addr)
> +static unsigned int ffaddr2pipehdl(struct dvobj_priv *pdvobj, u32 addr)
>   {
>   	unsigned int pipe = 0, ep_num = 0;
>   	struct usb_device *pusbd = pdvobj->pusbdev;

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150