[v2] wifi: plfxlc: Use eth_zero_addr() to assign zero address

[PATCH v2 -next] wifi: plfxlc: Use eth_zero_addr() to assign zero address

Posted by Xu Qiang 3 years, 10 months ago

Using eth_zero_addr() to assign zero address instead of memset().

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Xu Qiang <xuqiang36@huawei.com>
---
v2:
- fix typo in commit log
 drivers/net/wireless/purelifi/plfxlc/usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/purelifi/plfxlc/usb.c b/drivers/net/wireless/purelifi/plfxlc/usb.c
index 8519cf0adfff..39e54b3787d6 100644
--- a/drivers/net/wireless/purelifi/plfxlc/usb.c
+++ b/drivers/net/wireless/purelifi/plfxlc/usb.c
@@ -562,7 +562,7 @@ static void sta_queue_cleanup_timer_callb(struct timer_list *t)
 		if (tx->station[sidx].flag & STATION_HEARTBEAT_FLAG) {
 			tx->station[sidx].flag ^= STATION_HEARTBEAT_FLAG;
 		} else {
-			memset(tx->station[sidx].mac, 0, ETH_ALEN);
+			eth_zero_addr(tx->station[sidx].mac);
 			tx->station[sidx].flag = 0;
 		}
 	}
-- 
2.17.1

Re: [PATCH v2 -next] wifi: plfxlc: Use eth_zero_addr() to assign zero address

Posted by Kalle Valo 3 years, 9 months ago

Xu Qiang <xuqiang36@huawei.com> wrote:

> Using eth_zero_addr() to assign zero address instead of memset().
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Xu Qiang <xuqiang36@huawei.com>

Patch applied to wireless-next.git, thanks.

70c898d4bad1 wifi: plfxlc: Use eth_zero_addr() to assign zero address

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220701082935.110924-1-xuqiang36@huawei.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches