irqchip/xilinx: add explicit dependency on OF_ADDRESS

[PATCH] irqchip/xilinx: add explicit dependency on OF_ADDRESS

Posted by Jamie Iles 3 years, 9 months ago

Commit b84dc7f0e364 ("irqchip/xilinx: Remove microblaze+zynq
dependency") relaxed the dependencies on the Xilinx interrupt controller
to be OF only, but some OF architectures (s390 for example) do not
support OF_ADDRESS and so a build of the driver will result in undefined
references to of_iomap/iounmap and friends.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
---
 drivers/irqchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 1f23a6be7d88..bbb11cb8b0f7 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -298,7 +298,7 @@ config XTENSA_MX
 
 config XILINX_INTC
 	bool "Xilinx Interrupt Controller IP"
-	depends on OF
+	depends on OF_ADDRESS
 	select IRQ_DOMAIN
 	help
 	  Support for the Xilinx Interrupt Controller IP core.
-- 
2.34.1

Re: [PATCH] irqchip/xilinx: add explicit dependency on OF_ADDRESS

Posted by Michal Simek 3 years, 9 months ago


On 6/30/22 13:10, Jamie Iles wrote:
> Commit b84dc7f0e364 ("irqchip/xilinx: Remove microblaze+zynq
> dependency") relaxed the dependencies on the Xilinx interrupt controller
> to be OF only, but some OF architectures (s390 for example) do not
> support OF_ADDRESS and so a build of the driver will result in undefined
> references to of_iomap/iounmap and friends.
> 

Can you please add here fixed tag?

> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jamie Iles <jamie@jamieiles.com>
> ---
>   drivers/irqchip/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 1f23a6be7d88..bbb11cb8b0f7 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -298,7 +298,7 @@ config XTENSA_MX
>   
>   config XILINX_INTC
>   	bool "Xilinx Interrupt Controller IP"
> -	depends on OF
> +	depends on OF_ADDRESS
>   	select IRQ_DOMAIN
>   	help
>   	  Support for the Xilinx Interrupt Controller IP core.

When above added feel free to add my
Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal

[irqchip: irq/irqchip-fixes] irqchip/xilinx: Add explicit dependency on OF_ADDRESS

Posted by irqchip-bot for Jamie Iles 3 years, 9 months ago

The following commit has been merged into the irq/irqchip-fixes branch of irqchip:

Commit-ID:     fd31000d58f41588fa10128278efdab8474f5ce8
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/fd31000d58f41588fa10128278efdab8474f5ce8
Author:        Jamie Iles <jamie@jamieiles.com>
AuthorDate:    Thu, 30 Jun 2022 12:10:08 +01:00
Committer:     Marc Zyngier <maz@kernel.org>
CommitterDate: Fri, 01 Jul 2022 14:25:46 +01:00

irqchip/xilinx: Add explicit dependency on OF_ADDRESS

Commit b84dc7f0e364 ("irqchip/xilinx: Remove microblaze+zynq
dependency") relaxed the dependencies on the Xilinx interrupt controller
to be OF only, but some OF architectures (s390 for example) do not
support OF_ADDRESS and so a build of the driver will result in undefined
references to of_iomap/iounmap and friends.

Fixes: b84dc7f0e364 ("irqchip/xilinx: Remove microblaze+zynq dependency")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
Acked-by: Michal Simek <michal.simek@amd.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220630111008.3838307-1-jamie@jamieiles.com
---
 drivers/irqchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 1f23a6b..bbb11cb 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -298,7 +298,7 @@ config XTENSA_MX
 
 config XILINX_INTC
 	bool "Xilinx Interrupt Controller IP"
-	depends on OF
+	depends on OF_ADDRESS
 	select IRQ_DOMAIN
 	help
 	  Support for the Xilinx Interrupt Controller IP core.