staging: r8188eu: remove unneeded semicolon

[PATCH -next] staging: r8188eu: remove unneeded semicolon

Posted by Yang Li 3 years, 9 months ago

Eliminate the following coccicheck warning:
./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
index b5f6d41464db..5b0f66573d94 100644
--- a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
+++ b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
@@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
 		break;
 	default:
 		return false;
-	};
+	}
 
 	do {
 		pwrcfgcmd = pwrseqcmd[aryidx];
-- 
2.20.1.7.g153144c

Re: [PATCH -next] staging: r8188eu: remove unneeded semicolon

Posted by Martin Kaiser 3 years, 9 months ago

Thus wrote Yang Li (yang.lee@linux.alibaba.com):

> Eliminate the following coccicheck warning:
> ./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon

> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> index b5f6d41464db..5b0f66573d94 100644
> --- a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> +++ b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> @@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
>  		break;
>  	default:
>  		return false;
> -	};
> +	}

>  	do {
>  		pwrcfgcmd = pwrseqcmd[aryidx];
> -- 
> 2.20.1.7.g153144c

Thanks for spotting this.

Fixes: df8d0a55047b ("staging: r8188eu: make power sequences static")
Reviewed-by: Martin Kaiser <martin@kaiser.cx>

Re: [PATCH -next] staging: r8188eu: remove unneeded semicolon

Posted by Pavel Skripkin 3 years, 9 months ago

Hi Martin,

Martin Kaiser <lists@kaiser.cx> says:
> Thus wrote Yang Li (yang.lee@linux.alibaba.com):
> 
>> Eliminate the following coccicheck warning:
>> ./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon
> 
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>> ---
>>  drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>> diff --git a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
>> index b5f6d41464db..5b0f66573d94 100644
>> --- a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
>> +++ b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
>> @@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
>>  		break;
>>  	default:
>>  		return false;
>> -	};
>> +	}
> 
>>  	do {
>>  		pwrcfgcmd = pwrseqcmd[aryidx];
>> -- 
>> 2.20.1.7.g153144c
> 
> Thanks for spotting this.
> 
> Fixes: df8d0a55047b ("staging: r8188eu: make power sequences static")

^^^^^^^^^^^^^^^^^^^^^^^^^^

No need to backport code-style warning, so Fixes: is not needed here.




Thanks,
--Pavel Skripkin

Re: [PATCH -next] staging: r8188eu: remove unneeded semicolon

Posted by Dan Carpenter 3 years, 9 months ago

On Fri, Jul 01, 2022 at 10:58:58PM +0300, Pavel Skripkin wrote:
> Hi Martin,
> 
> Martin Kaiser <lists@kaiser.cx> says:
> > Thus wrote Yang Li (yang.lee@linux.alibaba.com):
> > 
> > > Eliminate the following coccicheck warning:
> > > ./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon
> > 
> > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > > ---
> > >  drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > > diff --git a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> > > index b5f6d41464db..5b0f66573d94 100644
> > > --- a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> > > +++ b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> > > @@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
> > >  		break;
> > >  	default:
> > >  		return false;
> > > -	};
> > > +	}
> > 
> > >  	do {
> > >  		pwrcfgcmd = pwrseqcmd[aryidx];
> > > -- 
> > > 2.20.1.7.g153144c
> > 
> > Thanks for spotting this.
> > 
> > Fixes: df8d0a55047b ("staging: r8188eu: make power sequences static")
> 
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> No need to backport code-style warning, so Fixes: is not needed here.
> 

The Fixes tag doesn't have to do with backporting...

I do think it should only be used for bugs.  So I would not have used it
here.  But other people do encourage it for style issues so I have given
up fighting about that.

regards,
dan carpenter