kbuild: remove unused cmd_none in scripts/Makefile.modinst

[PATCH] kbuild: remove unused cmd_none in scripts/Makefile.modinst

Posted by Masahiro Yamada 3 years, 9 months ago

Commit 65ce9c38326e ("kbuild: move module strip/compression code into
scripts/Makefile.modinst") added this unused code.

Perhaps, I thought cmd_none was useful for CONFIG_MODULE_COMPRESS_NONE,
but I did not use it after all.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 scripts/Makefile.modinst | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst
index c2c43a0ecfe0..16a02e9237d3 100644
--- a/scripts/Makefile.modinst
+++ b/scripts/Makefile.modinst
@@ -28,9 +28,6 @@ modules := $(patsubst $(extmod_prefix)%, $(dst)/%$(suffix-y), $(modules))
 __modinst: $(modules)
 	@:
 
-quiet_cmd_none =
-      cmd_none = :
-
 #
 # Installation
 #
-- 
2.32.0

Re: [PATCH] kbuild: remove unused cmd_none in scripts/Makefile.modinst

Posted by Nick Desaulniers 3 years, 9 months ago

On Thu, Jun 30, 2022 at 1:10 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Commit 65ce9c38326e ("kbuild: move module strip/compression code into
> scripts/Makefile.modinst") added this unused code.
>
> Perhaps, I thought cmd_none was useful for CONFIG_MODULE_COMPRESS_NONE,
> but I did not use it after all.

LGTM
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
>  scripts/Makefile.modinst | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst
> index c2c43a0ecfe0..16a02e9237d3 100644
> --- a/scripts/Makefile.modinst
> +++ b/scripts/Makefile.modinst
> @@ -28,9 +28,6 @@ modules := $(patsubst $(extmod_prefix)%, $(dst)/%$(suffix-y), $(modules))
>  __modinst: $(modules)
>         @:
>
> -quiet_cmd_none =
> -      cmd_none = :
> -
>  #
>  # Installation
>  #
> --
> 2.32.0
>


-- 
Thanks,
~Nick Desaulniers