PM / devfreq: tegra30: Add error message for devm_devfreq_add_device()

[PATCH v1] PM / devfreq: tegra30: Add error message for devm_devfreq_add_device()

Posted by Dmitry Osipenko 3 years, 9 months ago

It's difficult to notice that driver failed to probe by looking at KMSG
when devm_devfreq_add_device() fails. Add explicit error message for this
case.

Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 drivers/devfreq/tegra30-devfreq.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
index 30382bdfc655..f0d414b881e3 100644
--- a/drivers/devfreq/tegra30-devfreq.c
+++ b/drivers/devfreq/tegra30-devfreq.c
@@ -926,8 +926,10 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
 
 	devfreq = devm_devfreq_add_device(&pdev->dev, &tegra_devfreq_profile,
 					  "tegra_actmon", NULL);
-	if (IS_ERR(devfreq))
+	if (IS_ERR(devfreq)) {
+		dev_err(&pdev->dev, "Failed to add device: %pe\n", devfreq);
 		return PTR_ERR(devfreq);
+	}
 
 	return 0;
 }
-- 
2.36.1

Re: [PATCH v1] PM / devfreq: tegra30: Add error message for devm_devfreq_add_device()

Posted by Chanwoo Choi 3 years, 9 months ago

On 22. 6. 30. 16:57, Dmitry Osipenko wrote:
> It's difficult to notice that driver failed to probe by looking at KMSG
> when devm_devfreq_add_device() fails. Add explicit error message for this
> case.
> 
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> ---
>  drivers/devfreq/tegra30-devfreq.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index 30382bdfc655..f0d414b881e3 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -926,8 +926,10 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
>  
>  	devfreq = devm_devfreq_add_device(&pdev->dev, &tegra_devfreq_profile,
>  					  "tegra_actmon", NULL);
> -	if (IS_ERR(devfreq))
> +	if (IS_ERR(devfreq)) {
> +		dev_err(&pdev->dev, "Failed to add device: %pe\n", devfreq);
>  		return PTR_ERR(devfreq);
> +	}
>  
>  	return 0;
>  }

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi