[v1] net: tipc: fix possible refcount leak in tipc_sk_create()

[PATCH] net: tipc: fix possible refcount leak in tipc_sk_create()

Hangyu Hua posted 1 patch 3 years, 10 months ago

Diff against v1 v2
Download mbox

There is a newer version of this series

net/tipc/socket.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] net: tipc: fix possible refcount leak in tipc_sk_create()

Posted by Hangyu Hua 3 years, 10 months ago

Free sk in case tipc_sk_insert() fails.

Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
---

v2: use a succinct commit log.

 net/tipc/socket.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 17f8c523e33b..43509c7e90fc 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -502,6 +502,7 @@ static int tipc_sk_create(struct net *net, struct socket *sock,
 	sock_init_data(sock, sk);
 	tipc_set_sk_state(sk, TIPC_OPEN);
 	if (tipc_sk_insert(tsk)) {
+		sk_free(sk);
 		pr_warn("Socket create failed; port number exhausted\n");
 		return -EINVAL;
 	}
-- 
2.25.1