[PATCH] block: remove "select BLK_RQ_IO_DATA_LEN" from BLK_CGROUP_IOCOST dependency

sunying@nj.iscas.ac.cn posted 1 patch 3 years, 10 months ago
block/Kconfig | 1 -
1 file changed, 1 deletion(-)
[PATCH] block: remove "select BLK_RQ_IO_DATA_LEN" from BLK_CGROUP_IOCOST dependency
Posted by sunying@nj.iscas.ac.cn 3 years, 10 months ago
From: Ying Sun <sunying@nj.iscas.ac.cn>

The configuration item BLK_RQ_IO_DATA_LEN is not declared in the kernel.
Select BLK_RQ_IO_DATA_LEN is meaningless which could be removed.

Signed-off-by: Ying Sun <sunying@nj.iscas.ac.cn>
---
 block/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/block/Kconfig b/block/Kconfig
index 50b17e260fa2..444c5ab3b67e 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -147,7 +147,6 @@ config BLK_CGROUP_FC_APPID
 config BLK_CGROUP_IOCOST
 	bool "Enable support for cost model based cgroup IO controller"
 	depends on BLK_CGROUP
-	select BLK_RQ_IO_DATA_LEN
 	select BLK_RQ_ALLOC_TIME
 	help
 	Enabling this option enables the .weight interface for cost
-- 
2.17.1
Re: [PATCH] block: remove "select BLK_RQ_IO_DATA_LEN" from BLK_CGROUP_IOCOST dependency
Posted by Jens Axboe 3 years, 10 months ago
On Wed, 29 Jun 2022 14:24:09 +0800, sunying@nj.iscas.ac.cn wrote:
> From: Ying Sun <sunying@nj.iscas.ac.cn>
> 
> The configuration item BLK_RQ_IO_DATA_LEN is not declared in the kernel.
> Select BLK_RQ_IO_DATA_LEN is meaningless which could be removed.
> 
> 

Applied, thanks!

[1/1] block: remove "select BLK_RQ_IO_DATA_LEN" from BLK_CGROUP_IOCOST dependency
      commit: b9a1c179bdfa133d28ab8b7d30631b0accdc2057

Best regards,
-- 
Jens Axboe
Re: [PATCH] block: remove "select BLK_RQ_IO_DATA_LEN" from BLK_CGROUP_IOCOST dependency
Posted by Christoph Hellwig 3 years, 10 months ago
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>