trace: atomic64_read(&ioc->vtime_rate) is assigned an extra semicolon

[PATCH] trace: atomic64_read(&ioc->vtime_rate) is assigned an extra semicolon

Posted by Li kunyu 3 years, 10 months ago

I think this semicolon could be deleted.

Signed-off-by: Li kunyu <kunyu@nfschina.com>
---
 include/trace/events/iocost.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
index e282ce02fa2d..6d1626e7a4ce 100644
--- a/include/trace/events/iocost.h
+++ b/include/trace/events/iocost.h
@@ -160,7 +160,7 @@ TRACE_EVENT(iocost_ioc_vrate_adj,
 
 	TP_fast_assign(
 		__assign_str(devname, ioc_name(ioc));
-		__entry->old_vrate = atomic64_read(&ioc->vtime_rate);;
+		__entry->old_vrate = atomic64_read(&ioc->vtime_rate);
 		__entry->new_vrate = new_vrate;
 		__entry->busy_level = ioc->busy_level;
 		__entry->read_missed_ppm = missed_ppm[READ];
-- 
2.18.2

Re: [PATCH] trace: atomic64_read(&ioc->vtime_rate) is assigned an extra semicolon

Posted by Steven Rostedt 3 years, 9 months ago

Jens,

Want to take this one? Or I can if you don't.

-- Steve


On Wed, 29 Jun 2022 11:00:13 +0800
Li kunyu <kunyu@nfschina.com> wrote:

> I think this semicolon could be deleted.
> 
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
>  include/trace/events/iocost.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
> index e282ce02fa2d..6d1626e7a4ce 100644
> --- a/include/trace/events/iocost.h
> +++ b/include/trace/events/iocost.h
> @@ -160,7 +160,7 @@ TRACE_EVENT(iocost_ioc_vrate_adj,
>  
>  	TP_fast_assign(
>  		__assign_str(devname, ioc_name(ioc));
> -		__entry->old_vrate = atomic64_read(&ioc->vtime_rate);;
> +		__entry->old_vrate = atomic64_read(&ioc->vtime_rate);
>  		__entry->new_vrate = new_vrate;
>  		__entry->busy_level = ioc->busy_level;
>  		__entry->read_missed_ppm = missed_ppm[READ];

Re: [PATCH] trace: atomic64_read(&ioc->vtime_rate) is assigned an extra semicolon

Posted by Jens Axboe 3 years, 9 months ago

On 7/11/22 2:55 PM, Steven Rostedt wrote:
> Jens,
> 
> Want to take this one? Or I can if you don't.

You can just include it in the trace commits, that's fine. Thanks!

-- 
Jens Axboe

Re: [PATCH] trace: atomic64_read(&ioc->vtime_rate) is assigned an extra semicolon

Posted by Steven Rostedt 3 years, 9 months ago

On Mon, 11 Jul 2022 14:57:51 -0600
Jens Axboe <axboe@kernel.dk> wrote:

> On 7/11/22 2:55 PM, Steven Rostedt wrote:
> > Jens,
> > 
> > Want to take this one? Or I can if you don't.  
> 
> You can just include it in the trace commits, that's fine. Thanks!
> 

Will do. I'm working on something to push for Linus this week, I'll include
it with that. I don't think this needs to wait till the merge window.

-- Steve