PM / devfreq: imx-bus: use NULL to pass a null pointer rather than zero

[PATCH] PM / devfreq: imx-bus: use NULL to pass a null pointer rather than zero

Posted by Colin Ian King 3 years, 10 months ago

The 3rd argument to the function of_get_property is a pointer and it is
being passed using 0. Use NULL instead.

Cleans up sparse warning:
warning: Using plain integer as NULL pointer

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/devfreq/imx-bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c
index f3f6e25053ed..f87067fc574d 100644
--- a/drivers/devfreq/imx-bus.c
+++ b/drivers/devfreq/imx-bus.c
@@ -59,7 +59,7 @@ static int imx_bus_init_icc(struct device *dev)
 	struct imx_bus *priv = dev_get_drvdata(dev);
 	const char *icc_driver_name;
 
-	if (!of_get_property(dev->of_node, "#interconnect-cells", 0))
+	if (!of_get_property(dev->of_node, "#interconnect-cells", NULL))
 		return 0;
 	if (!IS_ENABLED(CONFIG_INTERCONNECT_IMX)) {
 		dev_warn(dev, "imx interconnect drivers disabled\n");
-- 
2.35.3

Re: [PATCH] PM / devfreq: imx-bus: use NULL to pass a null pointer rather than zero

Posted by Chanwoo Choi 3 years, 9 months ago

On 22. 6. 24. 03:00, Colin Ian King wrote:
> The 3rd argument to the function of_get_property is a pointer and it is
> being passed using 0. Use NULL instead.
> 
> Cleans up sparse warning:
> warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/devfreq/imx-bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c
> index f3f6e25053ed..f87067fc574d 100644
> --- a/drivers/devfreq/imx-bus.c
> +++ b/drivers/devfreq/imx-bus.c
> @@ -59,7 +59,7 @@ static int imx_bus_init_icc(struct device *dev)
>  	struct imx_bus *priv = dev_get_drvdata(dev);
>  	const char *icc_driver_name;
>  
> -	if (!of_get_property(dev->of_node, "#interconnect-cells", 0))
> +	if (!of_get_property(dev->of_node, "#interconnect-cells", NULL))
>  		return 0;
>  	if (!IS_ENABLED(CONFIG_INTERCONNECT_IMX)) {
>  		dev_warn(dev, "imx interconnect drivers disabled\n");

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi