[PATCH v3 0/2] net: dp83822: fix interrupt floods

Enguerrand de Ribaucourt posted 2 patches 3 years, 10 months ago
[PATCH v3 0/2] net: dp83822: fix interrupt floods
Posted by Enguerrand de Ribaucourt 3 years, 10 months ago
The false carrier and RX error counters, once half full, produce interrupt
floods. Since we do not use these counters, these interrupts should be disabled.

v2: added Fixes: and patchset description 0/2
v3: Fixed Fixes: commit format

In-Reply-To: YqzAKguRaxr74oXh@lunn.ch
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")
Re: [PATCH v3 0/2] net: dp83822: fix interrupt floods
Posted by patchwork-bot+netdevbpf@kernel.org 3 years, 9 months ago
Hello:

This series was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 23 Jun 2022 15:46:43 +0200 you wrote:
> The false carrier and RX error counters, once half full, produce interrupt
> floods. Since we do not use these counters, these interrupts should be disabled.
> 
> v2: added Fixes: and patchset description 0/2
> v3: Fixed Fixes: commit format
> 
> In-Reply-To: YqzAKguRaxr74oXh@lunn.ch
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")

Here is the summary with links:
  - [v3,1/2] net: dp83822: disable false carrier interrupt
    https://git.kernel.org/netdev/net/c/c96614eeab66
  - [v3,2/2] net: dp83822: disable rx error interrupt
    https://git.kernel.org/netdev/net/c/0e597e2affb9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH v3 0/2] net: dp83822: fix interrupt floods
Posted by Andrew Lunn 3 years, 10 months ago
On Thu, Jun 23, 2022 at 03:46:43PM +0200, Enguerrand de Ribaucourt wrote:
> The false carrier and RX error counters, once half full, produce interrupt
> floods. Since we do not use these counters, these interrupts should be disabled.
> 
> v2: added Fixes: and patchset description 0/2
> v3: Fixed Fixes: commit format
> 
> In-Reply-To: YqzAKguRaxr74oXh@lunn.ch
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")

It is maybe only part of the netdev FAQ, but it states there, don't
post new versions of the patches in less than 24 hours. You need to
give people time to review the changes and make comments.

It is correct to append a Reviewed-by, but it should only be to the
patch which was actually reviewed. So please add my Reviewed-by to
just patch 1/2. The Fixes should also be on each individual patch, not
the 0/X patch, since that often gets lost in the noise.

    Andrew