[v2] staging: r8188eu: Make rtw_signal_stat_timer_hdl a static function

[PATCH v2] staging: r8188eu: Make rtw_signal_stat_timer_hdl a static function

Posted by Chang Yu 3 years, 10 months ago

Make rtw_signal_stat_timer_hdl a static function instead of a global
function.

Signed-off-by: Chang Yu <marcus.yu.56@gmail.com>
---
Changes in v2:
Added static for the definition as well

 drivers/staging/r8188eu/core/rtw_recv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
index cc91638a085d..6564e82ddd66 100644
--- a/drivers/staging/r8188eu/core/rtw_recv.c
+++ b/drivers/staging/r8188eu/core/rtw_recv.c
@@ -24,7 +24,7 @@ static u8 rtw_rfc1042_header[] = {
 	0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
 };
 
-void rtw_signal_stat_timer_hdl(struct timer_list *t);
+static void rtw_signal_stat_timer_hdl(struct timer_list *t);
 
 void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv)
 {
@@ -1794,7 +1794,7 @@ s32 rtw_recv_entry(struct recv_frame *precvframe)
 	return ret;
 }
 
-void rtw_signal_stat_timer_hdl(struct timer_list *t)
+static void rtw_signal_stat_timer_hdl(struct timer_list *t)
 {
 	struct adapter *adapter = from_timer(adapter, t, recvpriv.signal_stat_timer);
 	struct recv_priv *recvpriv = &adapter->recvpriv;
-- 
2.36.1

Re: [PATCH v2] staging: r8188eu: Make rtw_signal_stat_timer_hdl a static function

Posted by Philipp Hortmann 3 years, 10 months ago

On 6/23/22 06:38, Chang Yu wrote:
> Make rtw_signal_stat_timer_hdl a static function instead of a global
> function.
> 
> Signed-off-by: Chang Yu <marcus.yu.56@gmail.com>
> ---
> Changes in v2:
> Added static for the definition as well
> 
>   drivers/staging/r8188eu/core/rtw_recv.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
> index cc91638a085d..6564e82ddd66 100644
> --- a/drivers/staging/r8188eu/core/rtw_recv.c
> +++ b/drivers/staging/r8188eu/core/rtw_recv.c
> @@ -24,7 +24,7 @@ static u8 rtw_rfc1042_header[] = {
>   	0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
>   };
>   
> -void rtw_signal_stat_timer_hdl(struct timer_list *t);
> +static void rtw_signal_stat_timer_hdl(struct timer_list *t);
>   
>   void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv)
>   {
> @@ -1794,7 +1794,7 @@ s32 rtw_recv_entry(struct recv_frame *precvframe)
>   	return ret;
>   }
>   
> -void rtw_signal_stat_timer_hdl(struct timer_list *t)
> +static void rtw_signal_stat_timer_hdl(struct timer_list *t)
>   {
>   	struct adapter *adapter = from_timer(adapter, t, recvpriv.signal_stat_timer);
>   	struct recv_priv *recvpriv = &adapter->recvpriv;

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150