[PATCH] scsi: sg: Fix typo in comments

Jiang Jian posted 1 patch 3 years, 10 months ago
drivers/scsi/sg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] scsi: sg: Fix typo in comments
Posted by Jiang Jian 3 years, 10 months ago
there is an unexpected word 'is' in the comments that need to be dropped

file: drivers/scsi/sg.c
line: 697

* but is is possible that the app intended SG_DXFER_TO_DEV, because there

changed to:

* but is possible that the app intended SG_DXFER_TO_DEV, because there

Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
---
 drivers/scsi/sg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 118c7b4a8af2..047761f62b23 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -694,7 +694,7 @@ sg_write(struct file *filp, const char __user *buf, size_t count, loff_t * ppos)
 	}
 	/*
 	 * SG_DXFER_TO_FROM_DEV is functionally equivalent to SG_DXFER_FROM_DEV,
-	 * but is is possible that the app intended SG_DXFER_TO_DEV, because there
+	 * but is possible that the app intended SG_DXFER_TO_DEV, because there
 	 * is a non-zero input_size, so emit a warning.
 	 */
 	if (hp->dxfer_direction == SG_DXFER_TO_FROM_DEV) {
-- 
2.17.1
Re: [PATCH] scsi: sg: Fix typo in comments
Posted by Bart Van Assche 3 years, 10 months ago
On 6/22/22 08:30, Jiang Jian wrote:
> there is an unexpected word 'is' in the comments that need to be dropped
> 
> file: drivers/scsi/sg.c
> line: 697
> 
> * but is is possible that the app intended SG_DXFER_TO_DEV, because there
> 
> changed to:
> 
> * but is possible that the app intended SG_DXFER_TO_DEV, because there
> 
> Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
> ---
>   drivers/scsi/sg.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
> index 118c7b4a8af2..047761f62b23 100644
> --- a/drivers/scsi/sg.c
> +++ b/drivers/scsi/sg.c
> @@ -694,7 +694,7 @@ sg_write(struct file *filp, const char __user *buf, size_t count, loff_t * ppos)
>   	}
>   	/*
>   	 * SG_DXFER_TO_FROM_DEV is functionally equivalent to SG_DXFER_FROM_DEV,
> -	 * but is is possible that the app intended SG_DXFER_TO_DEV, because there
> +	 * but is possible that the app intended SG_DXFER_TO_DEV, because there
>   	 * is a non-zero input_size, so emit a warning.
>   	 */
>   	if (hp->dxfer_direction == SG_DXFER_TO_FROM_DEV) {

I do not agree with this change since the author of that comment 
probably wanted to write "[...] but it is possible [...]"

Bart.