[PATCH] arm64:kernel:Fix typo in comment

Jilin Yuan posted 1 patch 3 years, 10 months ago
arch/arm64/kernel/cpuinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] arm64:kernel:Fix typo in comment
Posted by Jilin Yuan 3 years, 10 months ago
Delete the redundant word 'ARM'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 arch/arm64/kernel/cpuinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
index 8eff0a34ffd4..bf61222c2c69 100644
--- a/arch/arm64/kernel/cpuinfo.c
+++ b/arch/arm64/kernel/cpuinfo.c
@@ -241,7 +241,7 @@ static struct kobj_type cpuregs_kobj_type = {
 };
 
 /*
- * The ARM ARM uses the phrase "32-bit register" to describe a register
+ * The ARM uses the phrase "32-bit register" to describe a register
  * whose upper 32 bits are RES0 (per C5.1.1, ARM DDI 0487A.i), however
  * no statement is made as to whether the upper 32 bits will or will not
  * be made use of in future, and between ARM DDI 0487A.c and ARM DDI
-- 
2.36.1
Re: [PATCH] arm64:kernel:Fix typo in comment
Posted by Russell King (Oracle) 3 years, 10 months ago
On Wed, Jun 22, 2022 at 05:19:51PM +0800, Jilin Yuan wrote:
> Delete the redundant word 'ARM'.

NAK. This patch is not appropriate.

"ARM" refers to Arm Ltd (using their old capitalisation) _and_ it also
refers to the _A_rchitecture _R_eferene _M_anual. So, "ARM ARM" is never
a typo anywhere in the kernel.

The only possible fixup would be to convert the _first_ "ARM" to be
"Arm" to follow the company's marketing whims, but we don't generally
go around updating stuff like that in the kernel unless other changes
are being made in that area or there is a real pressing need.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Re: [PATCH] arm64:kernel:Fix typo in comment
Posted by Marc Zyngier 3 years, 10 months ago
On 2022-06-22 10:19, Jilin Yuan wrote:
> Delete the redundant word 'ARM'.
> 
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
>  arch/arm64/kernel/cpuinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
> index 8eff0a34ffd4..bf61222c2c69 100644
> --- a/arch/arm64/kernel/cpuinfo.c
> +++ b/arch/arm64/kernel/cpuinfo.c
> @@ -241,7 +241,7 @@ static struct kobj_type cpuregs_kobj_type = {
>  };
> 
>  /*
> - * The ARM ARM uses the phrase "32-bit register" to describe a 
> register
> + * The ARM uses the phrase "32-bit register" to describe a register

No. the expression "ARM ARM" refers to the ARM Architecture Reference 
Manual.

         M.
-- 
Jazz is not dead. It just smells funny...