[PATCH] amt: remove unnecessary (void*) conversions.

Yu Zhe posted 1 patch 3 years, 10 months ago
drivers/net/amt.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
[PATCH] amt: remove unnecessary (void*) conversions.
Posted by Yu Zhe 3 years, 10 months ago
remove unnecessary void* type castings.

Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
---
 drivers/net/amt.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/amt.c b/drivers/net/amt.c
index be2719a3ba70..732f4c0daa73 100644
--- a/drivers/net/amt.c
+++ b/drivers/net/amt.c
@@ -1373,11 +1373,11 @@ static void amt_add_srcs(struct amt_dev *amt, struct amt_tunnel_list *tunnel,
 	int i;
 
 	if (!v6) {
-		igmp_grec = (struct igmpv3_grec *)grec;
+		igmp_grec = grec;
 		nsrcs = ntohs(igmp_grec->grec_nsrcs);
 	} else {
 #if IS_ENABLED(CONFIG_IPV6)
-		mld_grec = (struct mld2_grec *)grec;
+		mld_grec = grec;
 		nsrcs = ntohs(mld_grec->grec_nsrcs);
 #else
 	return;
@@ -1458,11 +1458,11 @@ static void amt_lookup_act_srcs(struct amt_tunnel_list *tunnel,
 	int i, j;
 
 	if (!v6) {
-		igmp_grec = (struct igmpv3_grec *)grec;
+		igmp_grec = grec;
 		nsrcs = ntohs(igmp_grec->grec_nsrcs);
 	} else {
 #if IS_ENABLED(CONFIG_IPV6)
-		mld_grec = (struct mld2_grec *)grec;
+		mld_grec = grec;
 		nsrcs = ntohs(mld_grec->grec_nsrcs);
 #else
 	return;
-- 
2.11.0
Re: [PATCH] amt: remove unnecessary (void*) conversions.
Posted by patchwork-bot+netdevbpf@kernel.org 3 years, 10 months ago
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 21 Jun 2022 10:16:48 +0800 you wrote:
> remove unnecessary void* type castings.
> 
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
> ---
>  drivers/net/amt.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Here is the summary with links:
  - amt: remove unnecessary (void*) conversions.
    https://git.kernel.org/netdev/net-next/c/d13a3205a717

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] amt: remove unnecessary (void*) conversions.
Posted by Jakub Kicinski 3 years, 10 months ago
On Tue, 21 Jun 2022 10:16:48 +0800 Yu Zhe wrote:
> remove unnecessary void* type castings.
> 
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>

Taehee, ack?  Your call.
Re: [PATCH] amt: remove unnecessary (void*) conversions.
Posted by Taehee Yoo 3 years, 10 months ago
Hi Yu Zhe,
Thanks a lot for your work!

On 6/22/22 14:26, Jakub Kicinski wrote:
> On Tue, 21 Jun 2022 10:16:48 +0800 Yu Zhe wrote:
>> remove unnecessary void* type castings.
>>
>> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
> 
> Taehee, ack?  Your call.

Hi Jakub,

It looks good to me.
I tested this and It works well.

Thanks a lot!

Acked-by: Taehee Yoo <ap420073@gmail.com>