This patch adds support for the newly available esd CAN-USB/3.

The USB protocol for the CAN-USB/3 is similar to the protocol used
for the CAN-USB/2 and the CAN-USB/Micro, so most of the code can be
shared for all three platforms.
Due to the fact that the CAN-USB/3 additionally supports CAN FD
some new functionality / functions are introduced.
Each occurrence of the term "usb2" within variables, function names,
etc. is changed to "usb" where it is shared for all three platforms.

The patch has been tested against / should apply to Marc's 
current testing branch:
commit 934135149578 ("Merge branch 'document-polarfire-soc-can-controller'")

Frank Jungclaus (1):
  can/esd_usb2: Added support for esd CAN-USB/3

 drivers/net/can/usb/esd_usb2.c | 647 ++++++++++++++++++++++++---------
 1 file changed, 467 insertions(+), 180 deletions(-)

-- 
2.25.1

Hello Frank,

thanks for your patch!

On 20.06.2022 22:26:02, Frank Jungclaus wrote:
> This patch adds support for the newly available esd CAN-USB/3.
> 
> The USB protocol for the CAN-USB/3 is similar to the protocol used
> for the CAN-USB/2 and the CAN-USB/Micro, so most of the code can be
> shared for all three platforms.
> Due to the fact that the CAN-USB/3 additionally supports CAN FD
> some new functionality / functions are introduced.
> Each occurrence of the term "usb2" within variables, function names,
> etc. is changed to "usb" where it is shared for all three platforms.

Can you split the patch into several ones. Please do the renaming first.
There's some seemingly unrelated reformatting, this could be a separate
patch, too. If this is too much work, you might take this into the
renaming patch. Then add the new device. This makes reviewing a lot
easier.

> The patch has been tested against / should apply to Marc's 
> current testing branch:
> commit 934135149578 ("Merge branch 'document-polarfire-soc-can-controller'")

Note: Better use the linux-can-next/master branch as a base, it will be
only fast forwarded. The testing branch will be rebased. As you don't
depend on any new features, it doesn't make any difference for you.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

On Tue, 2022-06-21 at 08:35 +0200, Marc Kleine-Budde wrote:
> Hello Frank,
> 
> thanks for your patch!
> 
> On 20.06.2022 22:26:02, Frank Jungclaus wrote:
> > This patch adds support for the newly available esd CAN-USB/3.
> > 
> > The USB protocol for the CAN-USB/3 is similar to the protocol used
> > for the CAN-USB/2 and the CAN-USB/Micro, so most of the code can be
> > shared for all three platforms.
> > Due to the fact that the CAN-USB/3 additionally supports CAN FD
> > some new functionality / functions are introduced.
> > Each occurrence of the term "usb2" within variables, function names,
> > etc. is changed to "usb" where it is shared for all three platforms.
> 
> Can you split the patch into several ones. Please do the renaming first.
> There's some seemingly unrelated reformatting, this could be a separate
> patch, too. If this is too much work, you might take this into the
> renaming patch. Then add the new device. This makes reviewing a lot
> easier.
> 
> > The patch has been tested against / should apply to Marc's 
> > current testing branch:
> > commit 934135149578 ("Merge branch 'document-polarfire-soc-can-controller'")
> 
> Note: Better use the linux-can-next/master branch as a base, it will be
> only fast forwarded. The testing branch will be rebased. As you don't
> depend on any new features, it doesn't make any difference for you.
> 
> regards,
> Marc
> 
Hello Marc, hello Vincent,

I did not expect to get a response that fast ;)

Thanks a lot for all your annotation work, suggestions and remarks.
I'll try to take them all into account. Than I'll send a series of
separate and much smaller and easier to handle patches.

Regards, Frank