arm64: dts: imx8mp: correct clock of pgc_ispdwp

[PATCH] arm64: dts: imx8mp: correct clock of pgc_ispdwp

Posted by Peng Fan (OSS) 3 years, 10 months ago

From: Peng Fan <peng.fan@nxp.com>

The deprecated DIV clk is previously part of the ISP composite clk, but
there is still one child clk(IMX8MP_CLK_MEDIA_ISP_ROOT) sourcing from
IMX8MP_CLK_MEDIA_ISP( previously IMX8MP_CLK_MEDIA_ISP_DIV)

So IMX8MP_CLK_MEDIA_ISP_ROOT should be used, not IMX8MP_CLK_MEDIA_ISP_DIV.

Fixes: 9d89189d5227 ("arm64: dts: imx8mp: Add MEDIAMIX power domains")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index b2f4a5f1f73c..2f970d458f80 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -595,7 +595,7 @@ pgc_hsiomix: power-domains@17 {
 					pgc_ispdwp: power-domain@18 {
 						#power-domain-cells = <0>;
 						reg = <IMX8MP_POWER_DOMAIN_MEDIAMIX_ISPDWP>;
-						clocks = <&clk IMX8MP_CLK_MEDIA_ISP_DIV>;
+						clocks = <&clk IMX8MP_CLK_MEDIA_ISP_ROOT>;
 					};
 				};
 			};
-- 
2.25.1

Re: [PATCH] arm64: dts: imx8mp: correct clock of pgc_ispdwp

Posted by Shawn Guo 3 years, 10 months ago

On Mon, Jun 20, 2022 at 11:20:44AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The deprecated DIV clk is previously part of the ISP composite clk, but
> there is still one child clk(IMX8MP_CLK_MEDIA_ISP_ROOT) sourcing from
> IMX8MP_CLK_MEDIA_ISP( previously IMX8MP_CLK_MEDIA_ISP_DIV)
> 
> So IMX8MP_CLK_MEDIA_ISP_ROOT should be used, not IMX8MP_CLK_MEDIA_ISP_DIV.
> 
> Fixes: 9d89189d5227 ("arm64: dts: imx8mp: Add MEDIAMIX power domains")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Applied, thanks!

Re: [PATCH] arm64: dts: imx8mp: correct clock of pgc_ispdwp

Posted by Laurent Pinchart 3 years, 10 months ago

Hi Peng,

Thank you for the patch.

On Mon, Jun 20, 2022 at 11:20:44AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The deprecated DIV clk is previously part of the ISP composite clk, but
> there is still one child clk(IMX8MP_CLK_MEDIA_ISP_ROOT) sourcing from
> IMX8MP_CLK_MEDIA_ISP( previously IMX8MP_CLK_MEDIA_ISP_DIV)
> 
> So IMX8MP_CLK_MEDIA_ISP_ROOT should be used, not IMX8MP_CLK_MEDIA_ISP_DIV.
> 
> Fixes: 9d89189d5227 ("arm64: dts: imx8mp: Add MEDIAMIX power domains")

Oops, my bad.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index b2f4a5f1f73c..2f970d458f80 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -595,7 +595,7 @@ pgc_hsiomix: power-domains@17 {
>  					pgc_ispdwp: power-domain@18 {
>  						#power-domain-cells = <0>;
>  						reg = <IMX8MP_POWER_DOMAIN_MEDIAMIX_ISPDWP>;
> -						clocks = <&clk IMX8MP_CLK_MEDIA_ISP_DIV>;
> +						clocks = <&clk IMX8MP_CLK_MEDIA_ISP_ROOT>;
>  					};
>  				};
>  			};

-- 
Regards,

Laurent Pinchart