drm: panel-orientation-quirks: Add quirk for Aya Neo Next

[PATCH v2] drm: panel-orientation-quirks: Add quirk for Aya Neo Next

Posted by Maccraft123 3 years, 10 months ago

From: Maya Matuszczyk <maccraft123mc@gmail.com>

The device is identified by "NEXT" in board name, however there are
different versions of it, "Next Advance" and "Next Pro", that have
different DMI board names.
Due to a production error a batch or two have their board names prefixed
by "AYANEO", this makes it 6 different DMI board names. To save some
space in final kernel image DMI_MATCH is used instead of
DMI_EXACT_MATCH.

Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>

---
Changes from v1:
- Changed it to use only one entry, with less exact match, as requested
  by Hans de Goede

---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 4e853acfd1e8..df87ba99a87c 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -152,6 +152,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYA NEO 2021"),
 		},
 		.driver_data = (void *)&lcd800x1280_rightside_up,
+	}, {	/* AYA NEO NEXT */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
+		  DMI_MATCH(DMI_BOARD_NAME, "NEXT"),
+		},
+		.driver_data = (void *)&lcd800x1280_rightside_up,
 	}, {	/* Chuwi HiBook (CWI514) */
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
-- 
2.36.1

Re: [PATCH v2] drm: panel-orientation-quirks: Add quirk for Aya Neo Next

Posted by Javier Martinez Canillas 3 years, 10 months ago

Hello Maya,

On 6/19/22 13:19, Maccraft123 wrote:
> From: Maya Matuszczyk <maccraft123mc@gmail.com>
> 
> The device is identified by "NEXT" in board name, however there are
> different versions of it, "Next Advance" and "Next Pro", that have
> different DMI board names.
> Due to a production error a batch or two have their board names prefixed
> by "AYANEO", this makes it 6 different DMI board names. To save some
> space in final kernel image DMI_MATCH is used instead of
> DMI_EXACT_MATCH.
> 
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> 

Patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat

Re: [PATCH v2] drm: panel-orientation-quirks: Add quirk for Aya Neo Next

Posted by Hans de Goede 3 years, 10 months ago

Hi,

On 6/19/22 13:46, Javier Martinez Canillas wrote:
> Hello Maya,
> 
> On 6/19/22 13:19, Maccraft123 wrote:
>> From: Maya Matuszczyk <maccraft123mc@gmail.com>
>>
>> The device is identified by "NEXT" in board name, however there are
>> different versions of it, "Next Advance" and "Next Pro", that have
>> different DMI board names.
>> Due to a production error a batch or two have their board names prefixed
>> by "AYANEO", this makes it 6 different DMI board names. To save some
>> space in final kernel image DMI_MATCH is used instead of
>> DMI_EXACT_MATCH.
>>
>> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
>>
> 
> Patch looks good to me.
> 
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

New version looks good to me too:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

I've some upcoming travel, so it would be good if someone
else can push this to drm-misc-fixes.

Regards,

Hans

Re: [PATCH v2] drm: panel-orientation-quirks: Add quirk for Aya Neo Next

Posted by Javier Martinez Canillas 3 years, 10 months ago

Hello Hans,

On 6/19/22 16:57, Hans de Goede wrote:
> Hi,
> 
> On 6/19/22 13:46, Javier Martinez Canillas wrote:
>> Hello Maya,
>>
>> On 6/19/22 13:19, Maccraft123 wrote:
>>> From: Maya Matuszczyk <maccraft123mc@gmail.com>
>>>
>>> The device is identified by "NEXT" in board name, however there are
>>> different versions of it, "Next Advance" and "Next Pro", that have
>>> different DMI board names.
>>> Due to a production error a batch or two have their board names prefixed
>>> by "AYANEO", this makes it 6 different DMI board names. To save some
>>> space in final kernel image DMI_MATCH is used instead of
>>> DMI_EXACT_MATCH.
>>>
>>> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
>>>
>>
>> Patch looks good to me.
>>
>> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> 
> New version looks good to me too:
> 
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> 
> I've some upcoming travel, so it would be good if someone
> else can push this to drm-misc-fixes.
> 

Sure, I've pushed to drm-misc-fixes now. Thanks!

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat