tty: Add N_CAN327 line discipline ID for ELM327 based CAN driver

[PATCH] tty: Add N_CAN327 line discipline ID for ELM327 based CAN driver

Posted by Max Staudt 3 years, 10 months ago

The actual driver will be added via the CAN tree.

Signed-off-by: Max Staudt <max@enpas.org>
---
Dear TTY maintainers,

The CAN people (well, a subset) have spoken and decided to accept the
can327 driver (formerly elmcan), an ldisc based CAN driver allowing CAN
experiments with commodity hardware.

After several rounds of reviews, the final condition is for you to
accept this patch for N_CAN327, so here goes - please add this new line
discipline to the list, and once this filters through, the driver itself
will be added to can-next :)


Thanks!

Max

---
 include/uapi/linux/tty.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/uapi/linux/tty.h b/include/uapi/linux/tty.h
index 9d0f06bfbac3..68aeae2addec 100644
--- a/include/uapi/linux/tty.h
+++ b/include/uapi/linux/tty.h
@@ -38,8 +38,9 @@
 #define N_NULL		27	/* Null ldisc used for error handling */
 #define N_MCTP		28	/* MCTP-over-serial */
 #define N_DEVELOPMENT	29	/* Manual out-of-tree testing */
+#define N_CAN327	30	/* ELM327 based OBD-II interfaces */
 
 /* Always the newest line discipline + 1 */
-#define NR_LDISCS	30
+#define NR_LDISCS	31
 
 #endif /* _UAPI_LINUX_TTY_H */
-- 
2.30.2

Re: [PATCH] tty: Add N_CAN327 line discipline ID for ELM327 based CAN driver

Posted by Greg Kroah-Hartman 3 years, 10 months ago

On Sat, Jun 18, 2022 at 08:01:34PM +0200, Max Staudt wrote:
> The actual driver will be added via the CAN tree.
> 
> Signed-off-by: Max Staudt <max@enpas.org>
> ---
> Dear TTY maintainers,
> 
> The CAN people (well, a subset) have spoken and decided to accept the
> can327 driver (formerly elmcan), an ldisc based CAN driver allowing CAN
> experiments with commodity hardware.
> 
> After several rounds of reviews, the final condition is for you to
> accept this patch for N_CAN327, so here goes - please add this new line
> discipline to the list, and once this filters through, the driver itself
> will be added to can-next :)

Great, will go to Linus before 5.19-final is out.

thanks,

greg k-h

Re: [PATCH] tty: Add N_CAN327 line discipline ID for ELM327 based CAN driver

Posted by Marc Kleine-Budde 3 years, 10 months ago

On 18.06.2022 20:01:34, Max Staudt wrote:
> The actual driver will be added via the CAN tree.
> 
> Signed-off-by: Max Staudt <max@enpas.org>

Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |