[PATCH] lib/lru_cache: Fix error free handing in lc_create.

wuchi posted 1 patch 3 years, 10 months ago
lib/lru_cache.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] lib/lru_cache: Fix error free handing in lc_create.
Posted by wuchi 3 years, 10 months ago
When kmem_cache_alloc in function lc_create returns null, we will
free the memory already allocated. The loop of kmem_cache_free
is wrong, especially:
  i = 0  ==> do wrong loop
  i > 0  ==> do not free element[0]

Signed-off-by: wuchi <wuchi.zero@gmail.com>
---
 lib/lru_cache.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/lru_cache.c b/lib/lru_cache.c
index 52313acbfa62..dc35464216d3 100644
--- a/lib/lru_cache.c
+++ b/lib/lru_cache.c
@@ -147,8 +147,8 @@ struct lru_cache *lc_create(const char *name, struct kmem_cache *cache,
 		return lc;
 
 	/* else: could not allocate all elements, give up */
-	for (i--; i; i--) {
-		void *p = element[i];
+	while (i) {
+		void *p = element[--i];
 		kmem_cache_free(cache, p - e_off);
 	}
 	kfree(lc);
-- 
2.20.1