[v1] cpufreq: Add MT8186 to cpufreq-dt-platdev blocklist

[PATCH] cpufreq: Add MT8186 to cpufreq-dt-platdev blocklist

Posted by AngeloGioacchino Del Regno 2 years, 3 months ago

This SoC shall use the mediatek-cpufreq driver, or the system will
crash upon any clock scaling request: add it to the cpufreq-dt-platdev
blocklist.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Fixes: 39b360102f3a ("cpufreq: mediatek: Add support for MT8186")
---
 drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index 96de1536e1cb..2c96de3f2d83 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -127,6 +127,7 @@ static const struct of_device_id blocklist[] __initconst = {
 	{ .compatible = "mediatek,mt8173", },
 	{ .compatible = "mediatek,mt8176", },
 	{ .compatible = "mediatek,mt8183", },
+	{ .compatible = "mediatek,mt8186", },
 	{ .compatible = "mediatek,mt8365", },
 	{ .compatible = "mediatek,mt8516", },
 
-- 
2.35.1

Re: [PATCH] cpufreq: Add MT8186 to cpufreq-dt-platdev blocklist

Posted by Matthias Brugger 2 years, 3 months ago


On 17/06/2022 11:06, AngeloGioacchino Del Regno wrote:
> This SoC shall use the mediatek-cpufreq driver, or the system will
> crash upon any clock scaling request: add it to the cpufreq-dt-platdev
> blocklist.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Fixes: 39b360102f3a ("cpufreq: mediatek: Add support for MT8186")

Fixes tag should be before any Rb, SoB etc tags.

With that:
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
>   drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index 96de1536e1cb..2c96de3f2d83 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -127,6 +127,7 @@ static const struct of_device_id blocklist[] __initconst = {
>   	{ .compatible = "mediatek,mt8173", },
>   	{ .compatible = "mediatek,mt8176", },
>   	{ .compatible = "mediatek,mt8183", },
> +	{ .compatible = "mediatek,mt8186", },
>   	{ .compatible = "mediatek,mt8365", },
>   	{ .compatible = "mediatek,mt8516", },
>

Re: [PATCH] cpufreq: Add MT8186 to cpufreq-dt-platdev blocklist

Posted by AngeloGioacchino Del Regno 2 years, 3 months ago

Il 17/06/22 12:16, Matthias Brugger ha scritto:
> 
> 
> On 17/06/2022 11:06, AngeloGioacchino Del Regno wrote:
>> This SoC shall use the mediatek-cpufreq driver, or the system will
>> crash upon any clock scaling request: add it to the cpufreq-dt-platdev
>> blocklist.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> Fixes: 39b360102f3a ("cpufreq: mediatek: Add support for MT8186")
> 
> Fixes tag should be before any Rb, SoB etc tags.

Oh wow, I really did that.

Sorry, I'll send a v2 in a minute or two.

> 
> With that:
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> 
>> ---
>>   drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
>> b/drivers/cpufreq/cpufreq-dt-platdev.c
>> index 96de1536e1cb..2c96de3f2d83 100644
>> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
>> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
>> @@ -127,6 +127,7 @@ static const struct of_device_id blocklist[] __initconst = {
>>       { .compatible = "mediatek,mt8173", },
>>       { .compatible = "mediatek,mt8176", },
>>       { .compatible = "mediatek,mt8183", },
>> +    { .compatible = "mediatek,mt8186", },
>>       { .compatible = "mediatek,mt8365", },
>>       { .compatible = "mediatek,mt8516", },